Add option to prefer DuckDuckGo#2996
Add option to prefer DuckDuckGo#2996droidmonkey merged 2 commits intokeepassxreboot:release/2.4.2from xf-:feature/preferDuckDuckGo
Conversation
|
I prefer no setting and just use duckduckgo full stop if that setting is enabled. |
|
@droidmonkey also a nice way. DuckDuckGo supports multiple definitions of favicons and should return the correct one. Only small disadvantage is the possible cache (Quote: Updates to favicons should occur automatically over a period of a few weeks.). As fallback (e.g. local network) is direct download. Other idea was a second button to force the second way, but that would complicate the UI or load both and select in popover (like advanced page into) has the same problem. |
| QUrl fallbackUrl = QUrl("https://icons.duckduckgo.com"); | ||
| fallbackUrl.setPath("/ip3/" + QUrl::toPercentEncoding(fullyQualifiedDomain) + ".ico"); | ||
|
|
||
| m_urlsToTry.append(fallbackUrl); |
There was a problem hiding this comment.
Remove the new setting and just change this from append to prepend.
There was a problem hiding this comment.
added ut afterwards to ensure the same order and hostIsIp afterwards
|
@droidmonkey Any rewording, because it is not a fallback option anymore |
|
"Use DuckDuckGo to download website icons" |
|
Changed it - ts files are loaded via translation service. didn't touch the source string. |
droidmonkey
left a comment
There was a problem hiding this comment.
I made the necessary changes
- Improve resilience against memory attacks - overwrite memory before free [#3020] - Prevent infinite save loop when location is unavailable [#3026] - Attempt to fix quitting application when shutdown or logout issued [#3199] - Support merging database custom data [#3002] - Fix opening URL's with non-http schemes [#3153] - Fix data loss due to not reading all database attachments if duplicates exist [#3180] - Fix entry context menu disabling when using keyboard navigation [#3199] - Fix behaviors when canceling an entry edit [#3199] - Fix processing of tray icon click and doubleclick [#3112] - Update group in preview widget when focused [#3199] - Prefer DuckDuckGo service over direct icon download (increases resolution) [#2996] - Remove apply button in application settings [#3019] - Use winqtdeploy on Windows to correct deployment issues [#3025] - Don't mark entry edit as modified when attribute selection changes [#3041] - Use console code page CP_UTF8 on Windows if supported [#3050] - Snap: Fix locking database with session lock [#3046] - Snap: Fix theming across Linux distributions [#3057] - Snap: Use SNAP_USER_COMMON and SNAP_USER_DATA directories [#3131] - KeeShare: Automatically enable WITH_XC_KEESHARE_SECURE if quazip is found [#3088] - macOS: Fix toolbar text when in dark mode [#2998] - macOS: Lock database on switching user [#3097] - macOS: Fix global Auto-Type when the database is locked [#3138] - Browser: Close popups when database is locked [#3093] - Browser: Add tests [#3016] - Browser: Don't create default group if custom group is enabled [#3127]
|
Shouldn't there be a "fallback to download icons from a website's favicon"? Or add a secondary flow somehow (related to #3169, since that's my current interaction). |
|
This PR puts duckduckgo first, then it tries the websites own ico. |
|
I tried to download a HTML source for the favicon:
Should I do a bug report? 😕 |
|
We don't parse the HTML, we only look at ./favicon.ico We will never parse the HTML |
Type of change
Description and Context
Some systems provide a favicon.ico out-of-box and set the correct icon via source code. Keepassxc will load the out-of-box icon and not a recognizable/brand icon. Only fix is by hand, because DuckDuckGo is only a fallback.
This patch adds an option to prefer DuckDuckGo over direct Favicon download.
(I tried to open an issue, but it got declined. Now i wrote a patch and fixed all icons in my kdbx.)
Fixes #2557
Screenshots
Testing strategy
Build works, test run, format only changes not related lines.
Checklist:
-DWITH_ASAN=ON. [REQUIRED]