Selenium Grid: Update metric name generated without part of empty#6772
Merged
JorTurFer merged 2 commits intokedacore:mainfrom May 12, 2025
Merged
Selenium Grid: Update metric name generated without part of empty#6772JorTurFer merged 2 commits intokedacore:mainfrom
JorTurFer merged 2 commits intokedacore:mainfrom
Conversation
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
JorTurFer
approved these changes
May 12, 2025
Member
|
/run-e2e selenium |
Member
|
Perhaps this could happen more often with other triggers as well. Shouldn't we have solved this in the We could have added something to that feature like: |
Member
|
good point @rickbrouwer, for the 2.17.1 release I will cherry-pick this particular version but for 2.18.0 we can reconsider and address this in a more general way as you outlined here |
Member
|
It's also a bit of a question for me whether this PR should be included with 2.17.1 since it's an improvement, not a fix. Improvements (such as performance tweaks or small updates) are not officially bug fixes in my opinion and therefore belong in a minor release. |
wozniakjan
pushed a commit
to wozniakjan/keda
that referenced
this pull request
May 15, 2025
…dacore#6772) * Selenium Grid: Update metric name generated without part of empty Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> * Update CHANGELOG with the PR Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> --------- Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
wozniakjan
pushed a commit
to wozniakjan/keda
that referenced
this pull request
May 15, 2025
…dacore#6772) * Selenium Grid: Update metric name generated without part of empty Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> * Update CHANGELOG with the PR Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> --------- Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
wozniakjan
added a commit
that referenced
this pull request
May 15, 2025
* fix: Admission Webhook blocks ScaledObject without metricType with fallback (#6702) * fix: Admission Webhook blocks ScaledObject without metricType with fallback Signed-off-by: rickbrouwer <rickbrouwer@gmail.com> * Add unit test Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * Add e2e test Signed-off-by: rickbrouwer <rickbrouwer@gmail.com> * Add more unit tests for scaledobject_types Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * Update changelog Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * Update Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> --------- Signed-off-by: rickbrouwer <rickbrouwer@gmail.com> Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> * fix: AWS SQS Queue queueURLFromEnv not working (#6713) Signed-off-by: rickbrouwer <rickbrouwer@gmail.com> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> * fix: Temporal scaler with API Key (#6707) Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: rickbrouwer <rickbrouwer@gmail.com> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> * fix: add default Operation in Azure Service Bus scaler (#6731) Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> * fix: ScalerCache gets the lock before operate the scalers (#6739) Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> * fix: Use pinned version for nginx image (#6737) * fix: Use pinned version for nginx image Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * . Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix panic in gcp scaler Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> --------- Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> * Selenium Grid: Update metric name generated without part of empty (#6772) * Selenium Grid: Update metric name generated without part of empty Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> * Update CHANGELOG with the PR Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> --------- Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> * chore: changelog and issue template v2.17.1 Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> --------- Signed-off-by: rickbrouwer <rickbrouwer@gmail.com> Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> Co-authored-by: rickbrouwer <rickbrouwer@gmail.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Co-authored-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
dpochopsky
pushed a commit
to dpochopsky/keda
that referenced
this pull request
Sep 12, 2025
…dacore#6772) * Selenium Grid: Update metric name generated without part of empty Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> * Update CHANGELOG with the PR Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> --------- Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> Signed-off-by: David Pochopsky <david.pochopsky@united.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the metric name generated from Grid scaler, since it is combined from trigger param
browserName,browserVersion, andplatformName. However, version and platform are optional and might be empty.Sometimes the name shown in the log was
selenium-grid-chrome--, which might cause confusion.With this change, this helps make the metric name meaningful, only appending non-empty values.
Checklist
Fixes #
Relates to #