fix: Improve e2e tests and small fixes by JorTurFer · Pull Request #6737 · kedacore/keda

JorTurFer · 2025-04-26T20:34:23Z

There is an issue with latest version of the nginx image that we use for e2e tests -> nginx/docker-nginx-unprivileged#302

As the image isn't relevant for the test, this PR pines the image to a working version and uses the GHCR registry instead of dockerhub.

This PR also fixes some small issues on gcp e2e and also remove some wrong error logging on external_push

Checklist

Commits are signed with Developer Certificate of Origin (DCO - learn more)

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

JorTurFer · 2025-04-26T20:34:31Z

/run-e2e
Update: You can check the progress here

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

JorTurFer · 2025-04-26T22:22:28Z

/run-e2e
Update: You can check the progress here

JorTurFer · 2025-04-27T00:20:11Z

/run-e2e
Update: You can check the progress here

JorTurFer · 2025-04-27T20:28:46Z

/run-e2e
Update: You can check the progress here

pkg/scalers/gcp_storage_scaler.go

Copilot

Pull Request Overview

This PR pins the nginx image version used in tests to 1.26 and switches from dockerhub (nginxinc) to the GHCR registry. Additionally, there is a change in error handling for the GCP storage scaler.

Reviewed Changes

Copilot reviewed 85 out of 85 changed files in this pull request and generated 1 comment.

File	Description
tests/internals/* (all affected test files)	Updated nginx image reference to "ghcr.io/nginx/nginx-unprivileged:1.26" for consistency across tests
pkg/scalers/gcp_storage_scaler.go	Modified error handling in the getItemCount loop

pkg/scalers/gcp_storage_scaler.go

JorTurFer · 2025-04-29T07:18:44Z

/run-e2e
Update: You can check the progress here

Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>

JorTurFer · 2025-04-29T12:09:09Z

/run-e2e
Update: You can check the progress here

Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>

JorTurFer · 2025-04-29T14:37:34Z

@zroubalik , I have updated external_push scaler to not print error on io.EOF as it's valid response, PTAL too

JorTurFer · 2025-04-29T14:38:21Z

/run-e2e
Update: You can check the progress here

Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>

JorTurFer · 2025-04-29T20:30:25Z

/run-e2e
Update: You can check the progress here

Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>

JorTurFer · 2025-04-29T22:22:32Z

/run-e2e
Update: You can check the progress here

Copilot

Pull Request Overview

This PR improves the e2e test stability by pinning the nginx image to a known good version from the GHCR registry and updating related error logging and connection retry handling. It updates the image references in multiple test files and makes a minor refactor in the GCP storage scaler to change the error handling order.

Reviewed Changes

Copilot reviewed 86 out of 86 changed files in this pull request and generated no comments.

File	Description
tests/*	Updates image references from "nginxinc/nginx-unprivileged" to "ghcr.io/nginx/nginx-unprivileged:1.26" (with or without alpine-slim) across different e2e test definitions
pkg/scalers/gcp_storage_scaler.go	Adjusts the error handling order when iterating over bucket items to pin error conditions
pkg/scalers/external_scaler.go	Adds improved error logging and back-off logging for retrying connection acquisition

Comments suppressed due to low confidence (2)

tests/internals/pause_scaledobject_explicitly/pause_scaledobject_explicitly_test.go:60

[nitpick] Some tests update the image from the 'alpine-slim' variant to a non-slim version. Please confirm that the change from 'alpine-slim' to '1.26' is intentional and does not affect test behavior.

-          image: nginxinc/nginx-unprivileged:alpine-slim

pkg/scalers/gcp_storage_scaler.go:207

In the updated error branch, the code accesses 'item.Size' after an error is detected. This may lead to undefined behavior if 'item' is not valid. Consider checking for 'iterator.Done' or other errors before accessing any fields on 'item'.

if err != nil {

JorTurFer · 2025-04-30T20:58:01Z

/run-e2e
Update: You can check the progress here

* fix: Use pinned version for nginx image Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * . Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix panic in gcp scaler Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> --------- Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

* fix: Use pinned version for nginx image Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * . Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix panic in gcp scaler Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> --------- Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>

* fix: Admission Webhook blocks ScaledObject without metricType with fallback (#6702) * fix: Admission Webhook blocks ScaledObject without metricType with fallback Signed-off-by: rickbrouwer <rickbrouwer@gmail.com> * Add unit test Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * Add e2e test Signed-off-by: rickbrouwer <rickbrouwer@gmail.com> * Add more unit tests for scaledobject_types Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * Update changelog Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * Update Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> --------- Signed-off-by: rickbrouwer <rickbrouwer@gmail.com> Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> * fix: AWS SQS Queue queueURLFromEnv not working (#6713) Signed-off-by: rickbrouwer <rickbrouwer@gmail.com> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> * fix: Temporal scaler with API Key (#6707) Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: rickbrouwer <rickbrouwer@gmail.com> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> * fix: add default Operation in Azure Service Bus scaler (#6731) Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> * fix: ScalerCache gets the lock before operate the scalers (#6739) Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> * fix: Use pinned version for nginx image (#6737) * fix: Use pinned version for nginx image Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * . Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix panic in gcp scaler Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> --------- Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> * Selenium Grid: Update metric name generated without part of empty (#6772) * Selenium Grid: Update metric name generated without part of empty Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> * Update CHANGELOG with the PR Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> --------- Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> * chore: changelog and issue template v2.17.1 Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> --------- Signed-off-by: rickbrouwer <rickbrouwer@gmail.com> Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> Co-authored-by: rickbrouwer <rickbrouwer@gmail.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Co-authored-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>

* fix: Use pinned version for nginx image Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * . Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix panic in gcp scaler Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> --------- Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: David Pochopsky <david.pochopsky@united.com>

fix: Use pinned version for nginx image

b7f8619

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

JorTurFer requested a review from a team as a code owner April 26, 2025 20:34

JorTurFer added 2 commits April 26, 2025 23:12

.

bae566f

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

fix panic in gcp scaler

5c720a7

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

JorTurFer enabled auto-merge (squash) April 26, 2025 22:26

zroubalik reviewed Apr 28, 2025

View reviewed changes

pkg/scalers/gcp_storage_scaler.go Show resolved Hide resolved

zroubalik requested a review from Copilot April 29, 2025 05:51

Merge branch 'main' into fix-e2e-tests

636ee95

Copilot AI reviewed Apr 29, 2025

View reviewed changes

pkg/scalers/gcp_storage_scaler.go Show resolved Hide resolved

update external_push_scaler_test to ensure the behaviour

8fb4ddc

Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>

.

8f659b1

Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>

JorTurFer added 2 commits April 29, 2025 22:26

add probe

47fe10a

Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>

add probe

090f313

Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>

improve reconection logic

5f55238

Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>

JorTurFer changed the title ~~fix: Use pinned version for nginx image~~ fix: Improve e2e tests Apr 29, 2025

JorTurFer requested a review from Copilot April 29, 2025 22:22

Copilot AI reviewed Apr 29, 2025

View reviewed changes

JorTurFer changed the title ~~fix: Improve e2e tests~~ fix: Improve e2e tests and small fixes Apr 30, 2025

wozniakjan mentioned this pull request Apr 30, 2025

Release: 2.17.1 #6724

Closed

18 tasks

zroubalik approved these changes Apr 30, 2025

View reviewed changes

wozniakjan approved these changes May 1, 2025

View reviewed changes

JorTurFer merged commit 9b954d4 into kedacore:main May 1, 2025
20 checks passed

JorTurFer deleted the fix-e2e-tests branch May 1, 2025 04:38

Conversation

JorTurFer commented Apr 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

JorTurFer commented Apr 26, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JorTurFer commented Apr 26, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JorTurFer commented Apr 27, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JorTurFer commented Apr 27, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

JorTurFer commented Apr 29, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JorTurFer commented Apr 29, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JorTurFer commented Apr 29, 2025

Uh oh!

JorTurFer commented Apr 29, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JorTurFer commented Apr 29, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JorTurFer commented Apr 29, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

JorTurFer commented Apr 30, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

JorTurFer commented Apr 26, 2025 •

edited

Loading

JorTurFer commented Apr 26, 2025 •

edited by github-actions bot

Loading

JorTurFer commented Apr 26, 2025 •

edited by github-actions bot

Loading

JorTurFer commented Apr 27, 2025 •

edited by github-actions bot

Loading

JorTurFer commented Apr 27, 2025 •

edited by github-actions bot

Loading

JorTurFer commented Apr 29, 2025 •

edited by github-actions bot

Loading

JorTurFer commented Apr 29, 2025 •

edited by github-actions bot

Loading

JorTurFer commented Apr 29, 2025 •

edited by github-actions bot

Loading

JorTurFer commented Apr 29, 2025 •

edited by github-actions bot

Loading

JorTurFer commented Apr 29, 2025 •

edited by github-actions bot

Loading

JorTurFer commented Apr 30, 2025 •

edited by github-actions bot

Loading