Skip to content

fix: add default Operation in Azure Service Bus scaler#6731

Merged
wozniakjan merged 2 commits intokedacore:mainfrom
rickbrouwer:issue-6730
Apr 30, 2025
Merged

fix: add default Operation in Azure Service Bus scaler#6731
wozniakjan merged 2 commits intokedacore:mainfrom
rickbrouwer:issue-6730

Conversation

@rickbrouwer
Copy link
Member

There was recently a refactor done in Azure Servicebus scaler released in 2.17 that appears to have accidentally removed the logic setting a default value for operation when it is not provided.

This PR should fix this.

Checklist

Fixes #6730

Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@wozniakjan
Copy link
Member

wozniakjan commented Apr 30, 2025

/run-e2e azure_service_bus
Update: You can check the progress here

@wozniakjan wozniakjan enabled auto-merge (squash) April 30, 2025 07:20
@wozniakjan wozniakjan merged commit 481cc80 into kedacore:main Apr 30, 2025
20 checks passed
@rickbrouwer rickbrouwer deleted the issue-6730 branch April 30, 2025 09:01
aliaqel-stripe pushed a commit to aliaqel-stripe/keda that referenced this pull request May 9, 2025
Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
aliaqel-stripe pushed a commit to aliaqel-stripe/keda that referenced this pull request May 9, 2025
Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
wozniakjan pushed a commit to wozniakjan/keda that referenced this pull request May 15, 2025
Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
wozniakjan pushed a commit to wozniakjan/keda that referenced this pull request May 15, 2025
Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
wozniakjan added a commit that referenced this pull request May 15, 2025
* fix: Admission Webhook blocks ScaledObject without metricType with fallback (#6702)

* fix: Admission Webhook blocks ScaledObject without metricType with fallback

Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>

* Add unit test

Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>

* Add e2e test

Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>

* Add more unit tests for scaledobject_types

Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>

* Update changelog

Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>

* Update

Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>

---------

Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>

* fix: AWS SQS Queue queueURLFromEnv not working (#6713)

Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>

* fix: Temporal scaler with API Key (#6707)

Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>

* fix: add default Operation in Azure Service Bus scaler (#6731)

Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>

* fix: ScalerCache gets the lock before operate the scalers (#6739)

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>

* fix: Use pinned version for nginx image (#6737)

* fix: Use pinned version for nginx image

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

* .

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

* fix panic in gcp scaler

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

---------

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>

* Selenium Grid: Update metric name generated without part of empty (#6772)

* Selenium Grid: Update metric name generated without part of empty

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>

* Update CHANGELOG with the PR

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>

---------

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>

* chore: changelog and issue template v2.17.1

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>

---------

Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
Co-authored-by: rickbrouwer <rickbrouwer@gmail.com>
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Co-authored-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
dpochopsky pushed a commit to dpochopsky/keda that referenced this pull request Sep 12, 2025
Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
Signed-off-by: David Pochopsky <david.pochopsky@united.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optional field Operation is now mandatory in Azure Service Bus scaler

3 participants