fix(vcpkg-ports): Ecosystem port consistency audit fixes#563
Merged
Conversation
…port The logger_system portfile explicitly sets -DLOGGER_USE_THREAD_SYSTEM=OFF, making the kcenon-thread-system dependency unused. Remove it to avoid unnecessary compile time for consumers. Closes #559
The network_system source vcpkg.json declares zlib >= 1.3 as a core dependency for message compression, but the port was missing it. Consumers could encounter link errors without this dependency. Closes #560
… feature The network feature enables HTTP metrics export which requires network_system, but the dependency array was empty. Without this, enabling the feature would fail at CMake configure time. Closes #561
…Case wrappers All 4 upstream systems completed snake_case install(EXPORT) migration: - logger_system (kcenon/logger_system#502) - container_system (kcenon/container_system#424) - database_system (kcenon/database_system#455) - network_system (kcenon/network_system#843) Update portfile vcpkg_cmake_config_fixup() to use snake_case PACKAGE_NAME and CONFIG_PATH directly, removing the manual wrapper config files that were added as a stopgap in #554. Closes #562
10 tasks
kcenon
added a commit
that referenced
this pull request
Apr 13, 2026
* fix(vcpkg-ports): remove unused thread_system dep from logger_system port The logger_system portfile explicitly sets -DLOGGER_USE_THREAD_SYSTEM=OFF, making the kcenon-thread-system dependency unused. Remove it to avoid unnecessary compile time for consumers. Closes #559 * fix(vcpkg-ports): add missing zlib dependency to network_system port The network_system source vcpkg.json declares zlib >= 1.3 as a core dependency for message compression, but the port was missing it. Consumers could encounter link errors without this dependency. Closes #560 * fix(vcpkg-ports): add network_system dep to monitoring_system network feature The network feature enables HTTP metrics export which requires network_system, but the dependency array was empty. Without this, enabling the feature would fail at CMake configure time. Closes #561 * chore(vcpkg-ports): migrate PACKAGE_NAME to snake_case, remove PascalCase wrappers All 4 upstream systems completed snake_case install(EXPORT) migration: - logger_system (kcenon/logger_system#502) - container_system (kcenon/container_system#424) - database_system (kcenon/database_system#455) - network_system (kcenon/network_system#843) Update portfile vcpkg_cmake_config_fixup() to use snake_case PACKAGE_NAME and CONFIG_PATH directly, removing the manual wrapper config files that were added as a stopgap in #554. Closes #562
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Summary
Fix 4 port consistency issues identified during comprehensive vcpkg ecosystem audit:
dependency accuracy, missing dependencies, empty feature arrays, and stale PascalCase wrappers.
Change Type
Affected Components
vcpkg-ports/kcenon-logger-system/— removed unused dependencyvcpkg-ports/kcenon-network-system/— added missing zlib dependencyvcpkg-ports/kcenon-monitoring-system/— wired network feature dependencyvcpkg-ports/kcenon-{logger,container,database,network}-system/— snake_case migrationWhy
Problem Solved
kcenon-thread-systemas dependency but disabled it (-DLOGGER_USE_THREAD_SYSTEM=OFF) — wasted consumer build timezlibcore dependency — potential link failures for consumersnetworkfeature had empty dependency array — enabling the feature would fail at CMake configurePACKAGE_NAMEwith manual snake_case wrappers despite all upstream systems completing snake_case migrationRelated Issues
Where
Files Changed Summary
vcpkg-ports/kcenon-logger-system/vcpkg.jsonkcenon-thread-systemfrom depsvcpkg-ports/kcenon-network-system/vcpkg.jsonzlib >= 1.3to depsvcpkg-ports/kcenon-monitoring-system/vcpkg.jsonkcenon-network-systemto network featurevcpkg-ports/kcenon-logger-system/portfile.cmakevcpkg-ports/kcenon-container-system/portfile.cmakevcpkg-ports/kcenon-database-system/portfile.cmakevcpkg-ports/kcenon-network-system/portfile.cmakeHow
Implementation Highlights
vcpkg_cmake_config_fixup(PACKAGE_NAME PascalCase ...)tosnake_caseand removed 40+ lines of wrapper generation code across 4 portfilesUpstream Migration References
Test Plan
find_package(logger_system CONFIG)resolves without wrapperfind_package(container_system CONFIG)resolves without wrapperfind_package(database_system CONFIG)resolves without wrapperfind_package(network_system CONFIG)resolves without wrapperBreaking Changes
find_package(LoggerSystem CONFIG),find_package(ContainerSystem CONFIG), etc. (PascalCase) will no longer work via the port. Consumers should usefind_package(snake_case CONFIG).