Skip to content

fix(vcpkg-ports): Add network_system dependency to monitoring_system network feature #561

Description

@kcenon

Part of #558

What

The kcenon-monitoring-system port defines a network feature, but its dependency array is empty. The feature enables HTTP metrics export (OTLP, Prometheus) which requires network_system, yet the port does not pull it in.

  • Current: "network": { "description": "...", "dependencies": [] } (empty array)
  • Expected: Feature should depend on kcenon-network-system
  • Scope: vcpkg-ports/kcenon-monitoring-system/vcpkg.json

Why

  • The portfile already passes -DMONITORING_WITH_NETWORK_SYSTEM=${MONITORING_WITH_NETWORK} based on this feature
  • Without the dependency, enabling the feature won't install network_system, causing CMake configure to fail
  • Empty dependency arrays for features that clearly need libraries indicate an oversight

Where

  • vcpkg-ports/kcenon-monitoring-system/vcpkg.jsonfeatures.network.dependencies is []
  • vcpkg-ports/kcenon-monitoring-system/portfile.cmake — lines 18-21: feature check sets MONITORING_WITH_NETWORK

How

Technical Approach

  1. Update vcpkg-ports/kcenon-monitoring-system/vcpkg.json network feature:
    "network": {
      "description": "Enable network_system integration for HTTP metrics export (OTLP, Prometheus)",
      "dependencies": [
        "kcenon-network-system"
      ]
    }
  2. Mirror the change in kcenon/vcpkg-registry if applicable

Acceptance Criteria

  • network feature depends on kcenon-network-system
  • Port builds correctly with --feature network flag

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions