Skip to content

fix(vcpkg-ports): Remove contradictory thread_system dependency from logger_system port #559

Description

@kcenon

Part of #558

What

The kcenon-logger-system port declares kcenon-thread-system as a core dependency in its vcpkg.json, but the portfile explicitly disables it with -DLOGGER_USE_THREAD_SYSTEM=OFF.

  • Current: Port installs kcenon-thread-system (and its transitive dep simdutf) but never links against it
  • Expected: Port dependencies match what the build actually consumes
  • Scope: vcpkg-ports/kcenon-logger-system/vcpkg.json

Why

  • Consumers pay unnecessary compile time for kcenon-thread-system + simdutf installation
  • The portfile comment explicitly states: "upstream CMake does not link thread_system library properly in vcpkg mode"
  • Contradictory declared-but-disabled dependency confuses maintainers and consumers

Where

  • vcpkg-ports/kcenon-logger-system/vcpkg.json — line 10: "kcenon-thread-system" in dependencies
  • vcpkg-ports/kcenon-logger-system/portfile.cmake — line 23: -DLOGGER_USE_THREAD_SYSTEM=OFF

How

Technical Approach

  1. Remove "kcenon-thread-system" from vcpkg-ports/kcenon-logger-system/vcpkg.json dependencies array
  2. Verify the portfile's -DLOGGER_USE_THREAD_SYSTEM=OFF remains correct
  3. Mirror the change in kcenon/vcpkg-registry if applicable

Acceptance Criteria

  • kcenon-thread-system is not listed as a dependency in the logger_system port vcpkg.json
  • -DLOGGER_USE_THREAD_SYSTEM=OFF remains in portfile
  • Logger system port still builds and installs correctly without thread_system

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions