Skip to content

feat: sub-agent continuation chain hop (#196)#1

Merged
cael-dandelion-cult merged 1 commit intofeature/context-pressurefrom
elliott/subagent-continuation
Mar 5, 2026
Merged

feat: sub-agent continuation chain hop (#196)#1
cael-dandelion-cult merged 1 commit intofeature/context-pressurefrom
elliott/subagent-continuation

Conversation

@karmafeast
Copy link
Copy Markdown

Summary

Parse [[CONTINUE_DELEGATE:]] brackets from sub-agent output in the announce flow. When a sub-agent's findings contain a delegate signal, strip the brackets, spawn a new sub-agent as a child of the same requester session, and announce the stripped text normally.

What this enables

Shard-to-shard chain hops: delegate 1 reads data, emits [[CONTINUE_DELEGATE: task | silent-wake]], gateway parses it at the announce boundary and spawns delegate 2 automatically. No parent-session relay needed.

Implementation

  • 1 file changed: src/agents/subagent-announce.ts (+62/-3)
  • Bracket parsing via existing stripContinuationSignal() from tokens.ts
  • Chain spawn via existing spawnSubagentDirect() with inherited silentAnnounce/wakeOnReturn flags
  • Bounded by existing maxSpawnDepth safety cap
  • Delayed spawn supported (+Ns suffix), capped at 300s
  • Fire-and-forget spawn — doesn't block the announce flow

Tests

128/128 existing tests pass. Build clean.

Closes #196

Parse [[CONTINUE_DELEGATE:]] brackets from sub-agent output in the
announce flow (subagent-announce.ts). When a sub-agent's findings
contain a delegate signal, strip the brackets, spawn a new sub-agent
as a child of the same requester session, and announce the stripped
text normally.

This enables shard-to-shard chain hops: delegate 1 reads data,
emits [[CONTINUE_DELEGATE: task | silent-wake]], gateway parses it
at the announce boundary and spawns delegate 2 automatically.

The new chain hop inherits silentAnnounce/wakeOnReturn flags from
the signal, and is bounded by the existing maxSpawnDepth safety cap
in spawnSubagentDirect.

Implementation: ~55 lines in subagent-announce.ts. No new files.
128/128 existing tests pass.
@karmafeast karmafeast force-pushed the elliott/subagent-continuation branch from 396984d to 706adb9 Compare March 5, 2026 05:08
@cael-dandelion-cult cael-dandelion-cult merged commit 525a2ea into feature/context-pressure Mar 5, 2026
2 of 9 checks passed
cael-dandelion-cult added a commit that referenced this pull request Mar 6, 2026
1. Document delayed fan-out generation guard behavior in tool description
   and JSDoc (finding #1: delayed delegates self-cancel at tolerance=0)
2. Harmonize chain-hop timer with generationGuardTolerance config
   (finding #3: bracket chain-hop timers now honor tolerance, matching
   agent-runner delegate timer behavior)

Found by: web Codex review (figs dispatch)
karmafeast pushed a commit that referenced this pull request Mar 7, 2026
- 6 tests for maxChainLength enforcement via task-prefix [continuation:chain-hop:N]
  - Boundary enforcement (hop 9 → 10 >= 10 → block)
  - Cost cap blocking when chain length within bounds
  - Custom maxChainLength from config
  - First bracket-started hop (no prefix → hop 0)
- FINDINGS.md: P0 status corrected (committed at 5118e7a, not 'locally applied')
- FINDINGS.md: P1/P2 status updated (prince branches in progress)
- FINDINGS.md: WORK timer tolerance asymmetry documented
- FINDINGS.md: Path-dependency gap (bracket-started chains) documented (Codex 5.4 finding #1)

Test: OPENCLAW_TEST_FAST=1 npx vitest run src/agents/subagent-announce.chain-guard.test.ts
Result: 6/6 pass
karmafeast pushed a commit that referenced this pull request Mar 7, 2026
Bracket-origin delegate spawns now emit [continuation:chain-hop:N] prefix
matching the tool-origin path. This ensures the announce-side guard at
subagent-announce.ts:1346 can enforce maxChainLength identically for both
bracket-origin and tool-origin chains.

Before: [continuation] Delegated task (turn N/M): ...
After:  [continuation:chain-hop:N] Delegated task (turn N/M): ...

Addresses WORKORDER6-codex54.md Workstream B and Codex 5.4 finding #1.

Test: failing test written first (confirmed [continuation] prefix lacked
chain-hop:N), then fix applied. 41/41 agent-runner tests pass.
cael-dandelion-cult pushed a commit that referenced this pull request Apr 2, 2026
* feat: add QQ Bot channel extension

* fix(qqbot): add setupWizard to runtime plugin for onboard re-entry

* fix: fix review

* fix: fix review

* chore: sync lockfile and config-docs baseline for qqbot extension

* refactor: 移除图床服务器相关代码

* fix

* docs: 新增 QQ Bot 插件文档并修正链接路径

* refactor: remove credential backup functionality and update setup logic

- Deleted the credential backup module to streamline the codebase.
- Updated the setup surface to handle client secrets more robustly, allowing for configured secret inputs.
- Simplified slash commands by removing unused hot upgrade compatibility checks and related functions.
- Adjusted types to use SecretInput for client secrets in QQBot configuration.
- Modified bundled plugin metadata to allow additional properties in the config schema.

* feat: 添加本地媒体路径解析功能,修正 QQBot 媒体路径处理

* feat: 添加本地媒体路径解析功能,修正 QQBot 媒体路径处理

* feat: remove qqbot-media and qqbot-remind skills, add tests for config and setup

- Deleted the qqbot-media and qqbot-remind skills documentation files.
- Added unit tests for qqbot configuration and setup processes, ensuring proper handling of SecretRef-backed credentials and account configurations.
- Implemented tests for local media path remapping, verifying correct resolution of media file paths.
- Removed obsolete channel and remind tools, streamlining the codebase.

* feat: 更新 QQBot 配置模式,添加音频格式和账户定义

* feat: 添加 QQBot 频道管理和定时提醒技能,更新媒体路径解析功能

* fix

* feat: 添加 /bot-upgrade 指令以查看 QQBot 插件升级指引

* feat: update reminder and qq channel skills

* feat: 更新remind工具投递目标地址格式

* feat: Refactor QQBot payload handling and improve code documentation

- Simplified and clarified the structure of payload interfaces for Cron reminders and media messages.
- Enhanced the parsing function to provide clearer error messages and improved validation.
- Updated platform utility functions for better cross-platform compatibility and clearer documentation.
- Improved text parsing utilities for better readability and consistency in emoji representation.
- Optimized upload cache management with clearer comments and reduced redundancy.
- Integrated QQBot plugin into the bundled channel plugins and updated metadata for installation.

* OK apps/macos/Sources/OpenClaw/HostEnvSecurityPolicy.generated.swift

> openclaw@2026.3.26 check:bundled-channel-config-metadata /Users/yuehuali/code/PR/openclaw
> node --import tsx scripts/generate-bundled-channel-config-metadata.ts --check

[bundled-channel-config-metadata] stale generated output at src/config/bundled-channel-config-metadata.generated.ts
 ELIFECYCLE  Command failed with exit code 1.
 ELIFECYCLE  Command failed with exit code 1.

* feat: 添加 QQBot 渠道配置及相关账户设置

* fix(qqbot): resolve 14 high-priority bugs from PR openclaw#52986 review

DM routing (7 fixes):
- #1: DM slash-command replies use sendDmMessage(guildId) instead of sendC2CMessage(senderId)
- #2: DM qualifiedTarget uses qqbot:dm:${guildId} instead of qqbot:c2c:${senderId}
- #3: sendTextChunks adds DM branch
- #4: sendMarkdownReply adds DM branch for text and Base64 images
- #5: parseAndSendMediaTags maps DM to targetType:dm + guildId
- #6: sendTextToTarget DM branch uses sendDmMessage; MessageTarget adds guildId field
- #7: handleImage/Audio/Video/FilePayload add DM branches

Other high-priority fixes:
- #8: Fix sendC2CVoiceMessage/sendGroupVoiceMessage parameter misalignment
- #9: broadcastMessage uses groupOpenid instead of member_openid for group users
- #10: Unify KnownUser storage - proactive.ts delegates to known-users.ts
- #11: Remove invalid recordKnownUser calls for guild/DM users
- #12: sendGroupMessage uses sendAndNotify to trigger onMessageSent hook
- #13: sendPhoto channel unsupported returns error field
- #14: sendTextAfterMedia adds channel and dm branches

Type fixes:
- DeliverEventContext adds guildId field
- MediaTargetContext.targetType adds dm variant
- sendPlainTextReply imgMediaTarget adds DM branch

* fix(qqbot): resolve 2 blockers + 7 medium-priority bugs from PR openclaw#52986 review

Blocker-1: Remove unused dmPolicy config knob
- dmPolicy was declared in schema/types/plugin.json but never consumed at runtime
- Removed from config-schema.ts, types.ts, and openclaw.plugin.json
- allowFrom remains active (already wired into framework command-auth)

Blocker-2: Gate sensitive slash commands with allowFrom authorization
- SlashCommand interface adds requireAuth?: boolean
- SlashCommandContext adds commandAuthorized: boolean
- /bot-logs set to requireAuth: true (reads local log files)
- matchSlashCommand rejects unauthorized senders for requireAuth commands
- trySlashCommandOrEnqueue computes commandAuthorized from allowFrom config

Medium-priority fixes:
- #15: Strip non-HTTP/non-local markdown image tags to prevent path leakage
- #16: applyQQBotAccountConfig clears clientSecret when setting clientSecretFile and vice versa
- #17: getAdminMarkerFile sanitizes accountId to prevent path traversal
- #18: URGENT_COMMANDS uses exact match instead of startsWith prefix match
- #19: isCronExpression validates each token starts with a cron-valid character
- #20: --token format validation rejects malformed input without colon separator
- #21: resolveDefaultQQBotAccountId checks QQBOT_APP_ID environment variable

* test(qqbot): add focused tests for slash command authorization path

- Unauthorized sender rejected for /bot-logs (requireAuth: true)
- Authorized sender allowed for /bot-logs
- Non-requireAuth commands (/bot-ping, /bot-help, /bot-version) work for all senders
- Unknown slash commands return null (passthrough)
- Non-slash messages return null
- Usage query (/bot-logs ?) also gated by auth check

* fix(qqbot): align global TTS fallback with framework config resolution

- Extract isGlobalTTSAvailable to utils/audio-convert.ts, mirroring core
  resolveTtsConfig logic: check auto !== 'off', fall back to legacy
  enabled boolean, default to off when neither is set.
- Add pre-check in reply-dispatcher before calling globalTextToSpeech to
  avoid unnecessary TTS calls and noisy error logs when TTS is not
  configured.
- Remove inline as any casts; use OpenClawConfig type throughout.
- Refactor handleAudioPayload into flat early-return structure with
  unified send path (plugin TTS → global fallback → send).

* fix(qqbot): break ESM circular dependency causing multi-account startup crash

The bundled gateway chunk had a circular static import on the channel
chunk (gateway -> outbound-deliver -> channel, while channel dynamically
imports gateway). When two accounts start concurrently via Promise.all,
the first dynamic import triggers module graph evaluation; the circular
reference causes api exports (including runDiagnostics) to resolve as
undefined before the module finishes evaluating.

Fix: extract chunkText and TEXT_CHUNK_LIMIT from channel.ts into a new
text-utils.ts leaf module. outbound-deliver.ts now imports from
text-utils.ts, breaking the cycle. channel.ts re-exports for backward
compatibility.

* fix(qqbot): serialize gateway module import to prevent multi-account startup race

When multiple accounts start concurrently via Promise.all, each calls
await import('./gateway.js') independently. Due to ESM circular
dependencies in the bundled output, the first import can resolve
transitive exports as undefined before module evaluation completes.

Fix: cache the dynamic import promise in a module-level variable so all
concurrent startAccount calls share the same import, ensuring the
gateway module is fully evaluated before any account uses it.

* refactor(qqbot): remove startup greeting logic

Remove getStartupGreetingPlan and related startup greeting delivery:
- Delete startup-greeting.ts (greeting plan, marker persistence)
- Delete admin-resolver.ts (admin resolution, greeting dispatch)
- Remove startup greeting calls from gateway READY/RESUMED handlers
- Remove isFirstReadyGlobal flag and adminCtx

* fix(qqbot): skip octal escape decoding for Windows local paths

Windows paths like C:\Users\1\file.txt contain backslash-digit sequences
that were incorrectly matched as octal escape sequences and decoded,
corrupting the file path. Detect Windows local paths (drive letter or UNC
prefix) and skip the octal decoding step for them.

* fix bot issue

* feat: 支持 TTS 自动开关并清理配置中的 clientSecretFile

* docs: 添加 QQBot 配置和消息处理的设计说明

* rebase

* fix(qqbot): align slash-command auth with shared command-auth model

Route requireAuth:true slash commands (e.g. /bot-logs) through the
framework's api.registerCommand() so resolveCommandAuthorization()
applies commands.allowFrom.qqbot precedence and qqbot: prefix
normalization before any handler runs.

- slash-commands.ts: registerCommand() now auto-routes by requireAuth
  into two maps (commands / frameworkCommands); getFrameworkCommands()
  exports the auth-required set for framework registration; bot-help
  lists both maps
- index.ts: registerFull() iterates getFrameworkCommands() and calls
  api.registerCommand() for each; handler derives msgType from ctx.from,
  sends file attachments via sendDocument, supports multi-account via
  ctx.accountId
- gateway.ts (inbound): replace raw allowFrom string comparison with
  qqbotPlugin.config.formatAllowFrom() to strip qqbot: prefix and
  uppercase before matching event.senderId
- gateway.ts (pre-dispatch): remove stale auth computation; commandAuthorized
  is true (requireAuth:true commands never reach matchSlashCommand)
- command-auth.test.ts: add regression tests for qqbot: prefix
  normalization in the inbound commandAuthorized computation
- slash-commands.test.ts: update /bot-logs tests to expect null
  (command routed to framework, not in local registry)

* rebase and solve conflict

* fix(qqbot): preserve mixed env setup credentials

---------

Co-authored-by: yuehuali <yuehuali@tencent.com>
Co-authored-by: walli <walli@tencent.com>
Co-authored-by: WideLee <limkuan24@gmail.com>
Co-authored-by: Frank Yang <frank.ekn@gmail.com>
@elliott-dandelion-cult elliott-dandelion-cult deleted the elliott/subagent-continuation branch April 23, 2026 19:14
elliott-dandelion-cult added a commit that referenced this pull request May 1, 2026
…-gap todo

Pin the three observability surfaces (ctx.log.warn, emitAgentEvent,
onAgentEvent) that fire when reconcileSessionStoreCompactionCountAfterSuccess
rejects, and pin the behavior contract that handleCompactionEnd emits
completed=true regardless of reconcile outcome.

Add it.todo documenting the fire-and-forget gap (audit gap #1 from
wave-D bbcf2f3).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ronan-dandelion-cult pushed a commit that referenced this pull request May 8, 2026
…ore continue_delegate attachments + paired chainState fixes onto v2026.5.7

Lands the v5.7 canonical-line content for the continuation feature:

Squashed from PR #604 (HEAD 8fe4f71) — 7 commits cohort-byte-walked:
- ed117ab  feat(continuation): context-pressure + targeted returns squashed onto v2026.5.7 base (#598)
- 2023fcf  fix(continuation): clean rebased delegate config (lint cleanup)
- 81fb7d1  fix(matrix): prefer crypto backup status first (rebase-fix; defers HTTP roundtrip when crypto present)
- 7c229fa  fix(channels): honor declared credential env (introduces listBundledConfiguredChannelEnvSignalIds)
- 387753f  test(browser): avoid DNS in target swap fixture (loopback instead of DNS-dependent fixture)
- ea7661d  feat: restore continue_delegate attachments (WO-605: restores capability cohort flagged as regression at issue #605)
- 8fe4f71  fix(continuation): paired chainState persistence fixes (#606 P1 fixes; agent-runner.ts:2913 + delegate-dispatch.ts:103)

Closes #602 (workorder for v5.7 rebase)
Closes #605 (regression-restore continue_delegate attachments)
Refs #603 (compaction-on-opus-4.7 IDE-auth diagnostic; separate fix lane)

Cohort byte-walk + cosign-state at admin-merge:
- 🩸 cael multi-pass byte-walks (WO-605 substrate + 4 rebase-fix commits with 1 conditional on matrix sdk + ed117ab squash)
- 🌫 silas area-walks (continuation primitives + agent-runner.ts deep walk + WO-605 design+code-flow+zod validation; second-walker partial-cosign on matrix)
- 🌊 ronan full byte-walk (4 rebase-fixes + ed117ab squash + ea7661d WO-605)
- 🌻 elliott seat-state-prevents-cosign per substrate-condition: DNS resolver-path failure on elliott-host (Pi-hole at 10.0.0.10 timing out, systemd-resolved blocking before fallback to 10.0.0.1; gateway can't reach Discord/GitHub/OpenAI). Cure-home per cohort canon: openclaw-dns-client lane (no unilateral host changes per banked rule). Post-DNS-cure cosign on canonical-tip welcome.

3-of-4 cohort cosigns substantively converged + 1-deferred-pending-DNS-fix.

Open follow-up substrate (post-merge):
- Matrix sdk.ts:81f conditional cosign — Cael + Silas flagged 2 risk-surfaces wanting deeper Matrix-SDK expertise (resolveRoomKeyBackupTrustState null vs populated semantics; ??= falsy-but-not-null edge case). 🌻 has Intel/Arc seat-ownership; revisit when seat-state allows.
- Hedge-vs-main-path race finding (Ronan 1502335023 + Silas 1502340658 cohort byte-walk): theoretically-real cross-flow async race in hedge-persist; lower-frequency than P1 #1; PR-shipping fine; file as follow-on issue under 'hedge-persist race' for future-cohort.

Driven per figs's drive-forward + tighten-cron-to-5m directive at msg 1502329589 + 1502318362.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants