Skip to content

docs: Ronan prince review — 0 P0s, ship it#4

Merged
cael-dandelion-cult merged 1 commit intofeature/context-pressure-squashedfrom
ronan/pr-review
Mar 6, 2026
Merged

docs: Ronan prince review — 0 P0s, ship it#4
cael-dandelion-cult merged 1 commit intofeature/context-pressure-squashedfrom
ronan/pr-review

Conversation

@ronan-dandelion-cult
Copy link
Copy Markdown

Prince review from Ronan 🌊

Verdict: Ship it ✅

  • 0 P0s
  • 2 P1s (module-level Map leak potential, compaction delegate count race — neither blocking)
  • 3 P2s (cosmetic)

Full review at docs/review-assembly/pr-review-ronan.md

@cael-dandelion-cult cael-dandelion-cult merged commit 6320718 into feature/context-pressure-squashed Mar 6, 2026
2 of 9 checks passed
cael-dandelion-cult added a commit that referenced this pull request Mar 6, 2026
…ure band, compaction reset

1. Migrate delegate-pending from system event queue to dedicated per-session
   Map (delegatePendingFlags). Prevents buildQueuedSystemPrompt from draining
   the marker on intervening turns before delegate returns. (5.4 finding #2)

2. Fix context-pressure threshold shadowing: custom thresholds in (0.9, 1]
   are no longer unreachable due to fixed 90-band check order. Custom band
   is now evaluated before the fixed 90 band when thresholdPct >= 90.
   (5.4 finding #3, Copilot P1-4)

3. Reset lastContextPressureBand to 0 after compaction so context-pressure
   advisories re-arm for the next fill cycle. (5.4 finding #4)

4. Add 4 tests: threshold shadowing, sub-threshold rejection, 95-band
   above custom threshold, and band reset after compaction.

Found by: Codex 5.4 xhigh review (figs dispatch on Elliott's box)
cael-dandelion-cult pushed a commit that referenced this pull request Apr 2, 2026
* feat: add QQ Bot channel extension

* fix(qqbot): add setupWizard to runtime plugin for onboard re-entry

* fix: fix review

* fix: fix review

* chore: sync lockfile and config-docs baseline for qqbot extension

* refactor: 移除图床服务器相关代码

* fix

* docs: 新增 QQ Bot 插件文档并修正链接路径

* refactor: remove credential backup functionality and update setup logic

- Deleted the credential backup module to streamline the codebase.
- Updated the setup surface to handle client secrets more robustly, allowing for configured secret inputs.
- Simplified slash commands by removing unused hot upgrade compatibility checks and related functions.
- Adjusted types to use SecretInput for client secrets in QQBot configuration.
- Modified bundled plugin metadata to allow additional properties in the config schema.

* feat: 添加本地媒体路径解析功能,修正 QQBot 媒体路径处理

* feat: 添加本地媒体路径解析功能,修正 QQBot 媒体路径处理

* feat: remove qqbot-media and qqbot-remind skills, add tests for config and setup

- Deleted the qqbot-media and qqbot-remind skills documentation files.
- Added unit tests for qqbot configuration and setup processes, ensuring proper handling of SecretRef-backed credentials and account configurations.
- Implemented tests for local media path remapping, verifying correct resolution of media file paths.
- Removed obsolete channel and remind tools, streamlining the codebase.

* feat: 更新 QQBot 配置模式,添加音频格式和账户定义

* feat: 添加 QQBot 频道管理和定时提醒技能,更新媒体路径解析功能

* fix

* feat: 添加 /bot-upgrade 指令以查看 QQBot 插件升级指引

* feat: update reminder and qq channel skills

* feat: 更新remind工具投递目标地址格式

* feat: Refactor QQBot payload handling and improve code documentation

- Simplified and clarified the structure of payload interfaces for Cron reminders and media messages.
- Enhanced the parsing function to provide clearer error messages and improved validation.
- Updated platform utility functions for better cross-platform compatibility and clearer documentation.
- Improved text parsing utilities for better readability and consistency in emoji representation.
- Optimized upload cache management with clearer comments and reduced redundancy.
- Integrated QQBot plugin into the bundled channel plugins and updated metadata for installation.

* OK apps/macos/Sources/OpenClaw/HostEnvSecurityPolicy.generated.swift

> openclaw@2026.3.26 check:bundled-channel-config-metadata /Users/yuehuali/code/PR/openclaw
> node --import tsx scripts/generate-bundled-channel-config-metadata.ts --check

[bundled-channel-config-metadata] stale generated output at src/config/bundled-channel-config-metadata.generated.ts
 ELIFECYCLE  Command failed with exit code 1.
 ELIFECYCLE  Command failed with exit code 1.

* feat: 添加 QQBot 渠道配置及相关账户设置

* fix(qqbot): resolve 14 high-priority bugs from PR openclaw#52986 review

DM routing (7 fixes):
- #1: DM slash-command replies use sendDmMessage(guildId) instead of sendC2CMessage(senderId)
- #2: DM qualifiedTarget uses qqbot:dm:${guildId} instead of qqbot:c2c:${senderId}
- #3: sendTextChunks adds DM branch
- #4: sendMarkdownReply adds DM branch for text and Base64 images
- #5: parseAndSendMediaTags maps DM to targetType:dm + guildId
- #6: sendTextToTarget DM branch uses sendDmMessage; MessageTarget adds guildId field
- #7: handleImage/Audio/Video/FilePayload add DM branches

Other high-priority fixes:
- #8: Fix sendC2CVoiceMessage/sendGroupVoiceMessage parameter misalignment
- #9: broadcastMessage uses groupOpenid instead of member_openid for group users
- #10: Unify KnownUser storage - proactive.ts delegates to known-users.ts
- #11: Remove invalid recordKnownUser calls for guild/DM users
- #12: sendGroupMessage uses sendAndNotify to trigger onMessageSent hook
- #13: sendPhoto channel unsupported returns error field
- #14: sendTextAfterMedia adds channel and dm branches

Type fixes:
- DeliverEventContext adds guildId field
- MediaTargetContext.targetType adds dm variant
- sendPlainTextReply imgMediaTarget adds DM branch

* fix(qqbot): resolve 2 blockers + 7 medium-priority bugs from PR openclaw#52986 review

Blocker-1: Remove unused dmPolicy config knob
- dmPolicy was declared in schema/types/plugin.json but never consumed at runtime
- Removed from config-schema.ts, types.ts, and openclaw.plugin.json
- allowFrom remains active (already wired into framework command-auth)

Blocker-2: Gate sensitive slash commands with allowFrom authorization
- SlashCommand interface adds requireAuth?: boolean
- SlashCommandContext adds commandAuthorized: boolean
- /bot-logs set to requireAuth: true (reads local log files)
- matchSlashCommand rejects unauthorized senders for requireAuth commands
- trySlashCommandOrEnqueue computes commandAuthorized from allowFrom config

Medium-priority fixes:
- #15: Strip non-HTTP/non-local markdown image tags to prevent path leakage
- #16: applyQQBotAccountConfig clears clientSecret when setting clientSecretFile and vice versa
- #17: getAdminMarkerFile sanitizes accountId to prevent path traversal
- #18: URGENT_COMMANDS uses exact match instead of startsWith prefix match
- #19: isCronExpression validates each token starts with a cron-valid character
- #20: --token format validation rejects malformed input without colon separator
- #21: resolveDefaultQQBotAccountId checks QQBOT_APP_ID environment variable

* test(qqbot): add focused tests for slash command authorization path

- Unauthorized sender rejected for /bot-logs (requireAuth: true)
- Authorized sender allowed for /bot-logs
- Non-requireAuth commands (/bot-ping, /bot-help, /bot-version) work for all senders
- Unknown slash commands return null (passthrough)
- Non-slash messages return null
- Usage query (/bot-logs ?) also gated by auth check

* fix(qqbot): align global TTS fallback with framework config resolution

- Extract isGlobalTTSAvailable to utils/audio-convert.ts, mirroring core
  resolveTtsConfig logic: check auto !== 'off', fall back to legacy
  enabled boolean, default to off when neither is set.
- Add pre-check in reply-dispatcher before calling globalTextToSpeech to
  avoid unnecessary TTS calls and noisy error logs when TTS is not
  configured.
- Remove inline as any casts; use OpenClawConfig type throughout.
- Refactor handleAudioPayload into flat early-return structure with
  unified send path (plugin TTS → global fallback → send).

* fix(qqbot): break ESM circular dependency causing multi-account startup crash

The bundled gateway chunk had a circular static import on the channel
chunk (gateway -> outbound-deliver -> channel, while channel dynamically
imports gateway). When two accounts start concurrently via Promise.all,
the first dynamic import triggers module graph evaluation; the circular
reference causes api exports (including runDiagnostics) to resolve as
undefined before the module finishes evaluating.

Fix: extract chunkText and TEXT_CHUNK_LIMIT from channel.ts into a new
text-utils.ts leaf module. outbound-deliver.ts now imports from
text-utils.ts, breaking the cycle. channel.ts re-exports for backward
compatibility.

* fix(qqbot): serialize gateway module import to prevent multi-account startup race

When multiple accounts start concurrently via Promise.all, each calls
await import('./gateway.js') independently. Due to ESM circular
dependencies in the bundled output, the first import can resolve
transitive exports as undefined before module evaluation completes.

Fix: cache the dynamic import promise in a module-level variable so all
concurrent startAccount calls share the same import, ensuring the
gateway module is fully evaluated before any account uses it.

* refactor(qqbot): remove startup greeting logic

Remove getStartupGreetingPlan and related startup greeting delivery:
- Delete startup-greeting.ts (greeting plan, marker persistence)
- Delete admin-resolver.ts (admin resolution, greeting dispatch)
- Remove startup greeting calls from gateway READY/RESUMED handlers
- Remove isFirstReadyGlobal flag and adminCtx

* fix(qqbot): skip octal escape decoding for Windows local paths

Windows paths like C:\Users\1\file.txt contain backslash-digit sequences
that were incorrectly matched as octal escape sequences and decoded,
corrupting the file path. Detect Windows local paths (drive letter or UNC
prefix) and skip the octal decoding step for them.

* fix bot issue

* feat: 支持 TTS 自动开关并清理配置中的 clientSecretFile

* docs: 添加 QQBot 配置和消息处理的设计说明

* rebase

* fix(qqbot): align slash-command auth with shared command-auth model

Route requireAuth:true slash commands (e.g. /bot-logs) through the
framework's api.registerCommand() so resolveCommandAuthorization()
applies commands.allowFrom.qqbot precedence and qqbot: prefix
normalization before any handler runs.

- slash-commands.ts: registerCommand() now auto-routes by requireAuth
  into two maps (commands / frameworkCommands); getFrameworkCommands()
  exports the auth-required set for framework registration; bot-help
  lists both maps
- index.ts: registerFull() iterates getFrameworkCommands() and calls
  api.registerCommand() for each; handler derives msgType from ctx.from,
  sends file attachments via sendDocument, supports multi-account via
  ctx.accountId
- gateway.ts (inbound): replace raw allowFrom string comparison with
  qqbotPlugin.config.formatAllowFrom() to strip qqbot: prefix and
  uppercase before matching event.senderId
- gateway.ts (pre-dispatch): remove stale auth computation; commandAuthorized
  is true (requireAuth:true commands never reach matchSlashCommand)
- command-auth.test.ts: add regression tests for qqbot: prefix
  normalization in the inbound commandAuthorized computation
- slash-commands.test.ts: update /bot-logs tests to expect null
  (command routed to framework, not in local registry)

* rebase and solve conflict

* fix(qqbot): preserve mixed env setup credentials

---------

Co-authored-by: yuehuali <yuehuali@tencent.com>
Co-authored-by: walli <walli@tencent.com>
Co-authored-by: WideLee <limkuan24@gmail.com>
Co-authored-by: Frank Yang <frank.ekn@gmail.com>
ronan-dandelion-cult pushed a commit that referenced this pull request Apr 19, 2026
… mock (#176)

Scaffolds the in-repo ZooKeeper coordination SDK per the plan on
#175. PR 1 of 5.

Ships (no recipes yet — that's PR 2):
- src/plugin-sdk/zk.ts — public barrel; cheap contract types re-exported
  eagerly, createZkClient() as async factory that dynamically imports
  the heavy driver on first call
- src/plugin-sdk/zk/client.ts — wrapDriver, subscribeState, dispatcher
- src/plugin-sdk/zk/driver.ts — ZkDriver interface (ConnectionState,
  CreateMode, WatchEvent, ZkStat, driver factory signature)
- src/plugin-sdk/zk/driver-native.ts — adapter over the `zookeeper`
  (yfinkelstein) native npm package, dynamic-imported only on first
  createZkClient({}) call so a cold `import` of the subpath never
  touches native
- src/plugin-sdk/zk/driver-mock.ts — in-memory ZK respecting
  ephemeral/sequential + data/children watches + ephemeral cleanup on
  close/expire; exported so recipe tests (PR 2) can run without a
  running ensemble
- src/plugin-sdk/zk/errors.ts — typed ZkError hierarchy with toZkError()
  normalizer driven by error.code unions (no instanceof-driven control
  flow required at call sites)
- src/plugin-sdk/zk/paths.ts — pure helpers (joinPath, validatePath,
  featurePath) enforcing the /openclaw/<env>/<feature>/... convention
- src/plugin-sdk/zk.test.ts — 10 tests against the mock driver

Wired into the public SDK surface:
- scripts/lib/plugin-sdk-entrypoints.json adds "zk"
- package.json exports adds ./plugin-sdk/zk
- package.json optionalDependencies adds zookeeper@^7.2.0 — lazy compile,
  tolerated at install time
- src/config/types.zk.ts + types.openclaw.ts add the optional zk? field
- src/config/zod-schema.ts adds ZkConfigSchema (strict, all-optional)
  so `openclaw config set zk.hosts …` won't bounce on strict validation
- docs/plugins/zk.md — operator primer (setup, defaults, session
  lifecycle, quorum degradation)
- docs/plugins/zk-parity.md — path-prefix convention table +
  pre-registered wire-up evidence template (per Cael's #4 + #5 review
  gaps, landed in the foundation PR so PR 5 can't hand-wave)
- docs/.generated/plugin-sdk-api-baseline.sha256 regenerated for the
  new subpath

Optional-dep tolerance smoke (clean-box Docker):

    $ docker run --rm node:22-slim bash -c '
        mkdir /t && cd /t &&
        cat > package.json <<EOF
    { "name":"smoke","optionalDependencies":{"zookeeper":"^7.2.0"} }
    EOF
        npm install --silent && echo RESULT=$?'
    RESULT=0
    (zookeeper skipped — no build-essential; install succeeds anyway)

Verification:
- pnpm tsgo  — clean
- pnpm test src/plugin-sdk/zk.test.ts  — 10/10 pass
- pnpm build — emits dist/plugin-sdk/zk.js + dist/plugin-sdk/zk.d.ts;
  driver-native + client land as hashed dynamic-import chunks
- pnpm check — clean
- pnpm config:docs:check + pnpm plugin-sdk:api:check — hashes in sync

Related: karmaterminal/openclaw-bootstrap#629 (merged, fleet_lock.py
default fix closes bootstrap#623).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
karmafeast added a commit that referenced this pull request Apr 19, 2026
…dary tests

Folds the load-bearing delta from #190 into #188 (which Silas noted at
19:05Z he'd close in favor of #188) plus the two coverage gaps Ronan
self-flagged in his 19:09Z PR-author critical-eyes pass:

1. **Placement**: moved `continuationLine` from end-of-status (after
   `activationLine`) to immediately after `📚 ${contextLine}`.
   Continuation is context-adjacent signal — chain depth + pending/staged
   delegates live in the same operator-scan bucket as context pressure.
   Matches the semantics Silas's #190 landed on; makes the RFC §6.3
   framing ("where the context banner lives") visually literal.

2. **Partial-row test**: chain + staged only (pending=0, volitional=0)
   should render `chain 2/10 | 1 post-compaction staged` with the zero
   fields omitted entirely. Addresses Ronan crit #4 (no partial-row coverage).

3. **Plural boundary test**: `1 delegate pending` (singular) vs the
   existing full-row case which uses `2 delegates pending` (plural).
   Addresses Ronan crit #5 (pluralization only covered in chain-only).

Verification:
- pnpm tsgo — clean
- pnpm test src/auto-reply/status.test.ts — **61/61** (was 59/59)
- oxlint — 0 warnings, 0 errors on both touched files

Not changed (deliberately kept from #188 vs what #190 had):
- **Extracted helper** `formatContinuationStatusLine` (testability > IIFE).
- **Enabled-gate** returns `null` when `cfg.enabled !== true` — per RFC §6.3:
  "show only when `continuation.enabled === true` AND at least one field
  is non-zero". #190 omitted this gate; would display counters for a
  disabled-but-stale-counter session. Not what RFC specifies.
- **Static ESM imports** (vitest can't reliably resolve lazy `require('./*.js')`
  from .ts source; eyeball-verified no cycle — neither `continuation/*`
  nor `request-compaction-tool.ts` imports `auto-reply/status`).

Refs: #187, #190 (superseded
per Silas's 19:05Z note).
ronan-dandelion-cult pushed a commit that referenced this pull request Apr 20, 2026
… mock (#176)

Scaffolds the in-repo ZooKeeper coordination SDK per the plan on
#175. PR 1 of 5.

Ships (no recipes yet — that's PR 2):
- src/plugin-sdk/zk.ts — public barrel; cheap contract types re-exported
  eagerly, createZkClient() as async factory that dynamically imports
  the heavy driver on first call
- src/plugin-sdk/zk/client.ts — wrapDriver, subscribeState, dispatcher
- src/plugin-sdk/zk/driver.ts — ZkDriver interface (ConnectionState,
  CreateMode, WatchEvent, ZkStat, driver factory signature)
- src/plugin-sdk/zk/driver-native.ts — adapter over the `zookeeper`
  (yfinkelstein) native npm package, dynamic-imported only on first
  createZkClient({}) call so a cold `import` of the subpath never
  touches native
- src/plugin-sdk/zk/driver-mock.ts — in-memory ZK respecting
  ephemeral/sequential + data/children watches + ephemeral cleanup on
  close/expire; exported so recipe tests (PR 2) can run without a
  running ensemble
- src/plugin-sdk/zk/errors.ts — typed ZkError hierarchy with toZkError()
  normalizer driven by error.code unions (no instanceof-driven control
  flow required at call sites)
- src/plugin-sdk/zk/paths.ts — pure helpers (joinPath, validatePath,
  featurePath) enforcing the /openclaw/<env>/<feature>/... convention
- src/plugin-sdk/zk.test.ts — 10 tests against the mock driver

Wired into the public SDK surface:
- scripts/lib/plugin-sdk-entrypoints.json adds "zk"
- package.json exports adds ./plugin-sdk/zk
- package.json optionalDependencies adds zookeeper@^7.2.0 — lazy compile,
  tolerated at install time
- src/config/types.zk.ts + types.openclaw.ts add the optional zk? field
- src/config/zod-schema.ts adds ZkConfigSchema (strict, all-optional)
  so `openclaw config set zk.hosts …` won't bounce on strict validation
- docs/plugins/zk.md — operator primer (setup, defaults, session
  lifecycle, quorum degradation)
- docs/plugins/zk-parity.md — path-prefix convention table +
  pre-registered wire-up evidence template (per Cael's #4 + #5 review
  gaps, landed in the foundation PR so PR 5 can't hand-wave)
- docs/.generated/plugin-sdk-api-baseline.sha256 regenerated for the
  new subpath

Optional-dep tolerance smoke (clean-box Docker):

    $ docker run --rm node:22-slim bash -c '
        mkdir /t && cd /t &&
        cat > package.json <<EOF
    { "name":"smoke","optionalDependencies":{"zookeeper":"^7.2.0"} }
    EOF
        npm install --silent && echo RESULT=$?'
    RESULT=0
    (zookeeper skipped — no build-essential; install succeeds anyway)

Verification:
- pnpm tsgo  — clean
- pnpm test src/plugin-sdk/zk.test.ts  — 10/10 pass
- pnpm build — emits dist/plugin-sdk/zk.js + dist/plugin-sdk/zk.d.ts;
  driver-native + client land as hashed dynamic-import chunks
- pnpm check — clean
- pnpm config:docs:check + pnpm plugin-sdk:api:check — hashes in sync

Related: karmaterminal/openclaw-bootstrap#629 (merged, fleet_lock.py
default fix closes bootstrap#623).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants