refactor(admin): replace RPC logging interceptor by ijsong · Pull Request #508 · kakao/varlog

ijsong · 2023-07-06T10:02:52Z

What this PR does

This change replaces the RPC logging interceptor of admin from github.com/grpc-ecosystem/go-grpc-middleware with our simple interceptor. It makes the interceptor simple and lightweight.

ijsong · 2023-07-06T10:03:12Z

Current dependencies on/for this PR:

main
- PR bump(deps): go.opentelemetry.io/otel/metric from v0.26.0 to v1.16.0 #493
  - PR feat(all): add common flags for telemetry #494
    - PR refactor(metarepos): remove redundant metric mr.build_commit_results.duration #503
      - PR refactor(telemetry): add semantic conventions for varlog #505
        
        PR refactor(storagenode): remove the redundant initiation of metric sn.append.logs #506
        
        PR refactor(admin): replace RPC logging interceptor #508 👈
        
        PR feat(admin): add otelgrpc metric interceptor #509
        
        PR feat(telemetry): customize bucket size of process.runtime.go.gc.pause_ns #510
        
        PR feat(telemetry): customize bucket size of rpc.server.duration #511
        
        PR refactor(telemetry): move from pkg/util/telemetry to internal/telemetry #507

This comment was auto-generated by Graphite.

This change replaces the RPC logging interceptor of admin from `github.com/grpc-ecosystem/go-grpc-middleware` with our simple interceptor. It makes the interceptor simple and lightweight.

ijsong · 2023-07-28T03:48:39Z

@ijsong started a stack merge that includes this pull request via Graphite.

ijsong · 2023-07-28T03:50:38Z

@ijsong merged this pull request with Graphite.

ijsong requested a review from hungryjang as a code owner July 6, 2023 10:02

This was referenced Jul 6, 2023

bump(deps): go.opentelemetry.io/otel/metric from v0.26.0 to v1.16.0 #493

Merged

feat(all): add common flags for telemetry #494

Merged

refactor(metarepos): remove redundant metric mr.build_commit_results.duration #503

Merged

ijsong self-assigned this Jul 6, 2023

This was referenced Jul 6, 2023

refactor(telemetry): add semantic conventions for varlog #505

Merged

refactor(storagenode): remove the redundant initiation of metric sn.append.logs #506

Merged

refactor(telemetry): move from pkg/util/telemetry to internal/telemetry #507

Closed

This was referenced Jul 7, 2023

feat(admin): add otelgrpc metric interceptor #509

Merged

feat(telemetry): customize bucket size of process.runtime.go.gc.pause_ns #510

Merged

feat(telemetry): customize bucket size of rpc.server.duration #511

Merged

ijsong force-pushed the sn_dedup_metric_sn_append_logs branch from e8727bc to c2ad0af Compare July 11, 2023 13:23

ijsong force-pushed the admin_rpc_logging_interceptor branch from 7b66d5c to afc4100 Compare July 11, 2023 13:23

ijsong force-pushed the sn_dedup_metric_sn_append_logs branch from c2ad0af to 0f0d253 Compare July 18, 2023 14:45

ijsong force-pushed the admin_rpc_logging_interceptor branch from afc4100 to 093d269 Compare July 18, 2023 14:45

hungryjang approved these changes Jul 27, 2023

View reviewed changes

refactor(admin): replace RPC logging interceptor

5f2ec49

This change replaces the RPC logging interceptor of admin from `github.com/grpc-ecosystem/go-grpc-middleware` with our simple interceptor. It makes the interceptor simple and lightweight.

ijsong force-pushed the sn_dedup_metric_sn_append_logs branch from 0f0d253 to 07c025b Compare July 28, 2023 03:01

ijsong force-pushed the admin_rpc_logging_interceptor branch from 093d269 to 5f2ec49 Compare July 28, 2023 03:01

Base automatically changed from sn_dedup_metric_sn_append_logs to main July 28, 2023 03:50

ijsong merged commit e9b46ad into main Jul 28, 2023

ijsong deleted the admin_rpc_logging_interceptor branch July 28, 2023 03:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(admin): replace RPC logging interceptor#508

refactor(admin): replace RPC logging interceptor#508
ijsong merged 1 commit intomainfrom
admin_rpc_logging_interceptor

ijsong commented Jul 6, 2023

Uh oh!

ijsong commented Jul 6, 2023 •

edited

Loading

Uh oh!

ijsong commented Jul 28, 2023

Uh oh!

ijsong commented Jul 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ijsong commented Jul 6, 2023

What this PR does

Uh oh!

ijsong commented Jul 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ijsong commented Jul 28, 2023

Uh oh!

ijsong commented Jul 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ijsong commented Jul 6, 2023 •

edited

Loading