Skip to content

refactor(metarepos): remove redundant metric mr.build_commit_results.duration#503

Merged
ijsong merged 1 commit intomainfrom
mr_dedup_build_commit_results_duration
Jul 28, 2023
Merged

refactor(metarepos): remove redundant metric mr.build_commit_results.duration#503
ijsong merged 1 commit intomainfrom
mr_dedup_build_commit_results_duration

Conversation

@ijsong
Copy link
Copy Markdown
Member

@ijsong ijsong commented Jul 3, 2023

What this PR does

Remove the redundant metric, which is mr.build_commit_results.duration.

@ijsong ijsong self-assigned this Jul 3, 2023
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Patch coverage has no change and project coverage change: -0.12 ⚠️

Comparison is base (ac82770) 62.28% compared to head (36b044b) 62.16%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           telemetry_flags     #503      +/-   ##
===================================================
- Coverage            62.28%   62.16%   -0.12%     
===================================================
  Files                  133      133              
  Lines                18447    18442       -5     
===================================================
- Hits                 11489    11465      -24     
- Misses                6387     6405      +18     
- Partials               571      572       +1     
Impacted Files Coverage Δ
internal/metarepos/raft_metadata_repository.go 76.93% <ø> (-0.02%) ⬇️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ijsong ijsong force-pushed the telemetry_flags branch from fd62edb to fcacd1a Compare July 28, 2023 03:01
@ijsong ijsong force-pushed the mr_dedup_build_commit_results_duration branch from bca6e0c to 44eead0 Compare July 28, 2023 03:01
@ijsong
Copy link
Copy Markdown
Member Author

ijsong commented Jul 28, 2023

@ijsong started a stack merge that includes this pull request via Graphite.

Base automatically changed from telemetry_flags to main July 28, 2023 03:49
@ijsong ijsong merged commit 8ec6729 into main Jul 28, 2023
@ijsong ijsong deleted the mr_dedup_build_commit_results_duration branch July 28, 2023 03:49
@ijsong
Copy link
Copy Markdown
Member Author

ijsong commented Jul 28, 2023

@ijsong merged this pull request with Graphite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants