Skip to content

feat(all): add common flags for telemetry#494

Merged
ijsong merged 1 commit intomainfrom
telemetry_flags
Jul 28, 2023
Merged

feat(all): add common flags for telemetry#494
ijsong merged 1 commit intomainfrom
telemetry_flags

Conversation

@ijsong
Copy link
Copy Markdown
Member

@ijsong ijsong commented Jun 26, 2023

No description provided.

@ijsong ijsong self-assigned this Jun 26, 2023
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 26, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.09 ⚠️

Comparison is base (87efc3f) 62.19% compared to head (4e4d262) 62.10%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           bump_opentelemetry     #494      +/-   ##
======================================================
- Coverage               62.19%   62.10%   -0.09%     
======================================================
  Files                     133      133              
  Lines                   18502    18461      -41     
======================================================
- Hits                    11508    11466      -42     
  Misses                   6417     6417              
- Partials                  577      578       +1     
Impacted Files Coverage Δ
internal/metarepos/raft_metadata_repository.go 77.22% <ø> (+0.25%) ⬆️
internal/metarepos/telemetry.go 100.00% <100.00%> (+29.62%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ijsong ijsong force-pushed the bump_opentelemetry branch from 1a07989 to 8f4b941 Compare June 26, 2023 02:34
@ijsong ijsong force-pushed the telemetry_flags branch from dbded81 to 6137981 Compare June 26, 2023 02:34
@ijsong ijsong force-pushed the bump_opentelemetry branch from 8f4b941 to 87efc3f Compare June 29, 2023 02:41
@ijsong ijsong force-pushed the telemetry_flags branch from 6137981 to 4e4d262 Compare June 29, 2023 02:41
@ijsong ijsong force-pushed the bump_opentelemetry branch from 87efc3f to 8372ff4 Compare June 29, 2023 10:01
@ijsong ijsong force-pushed the telemetry_flags branch from 4e4d262 to 06c57ef Compare June 29, 2023 10:02
@ijsong ijsong force-pushed the bump_opentelemetry branch from 8372ff4 to 479ace5 Compare July 3, 2023 23:12
@ijsong ijsong force-pushed the telemetry_flags branch from 06c57ef to ac82770 Compare July 3, 2023 23:12
@ijsong ijsong force-pushed the bump_opentelemetry branch from 479ace5 to f38a9a1 Compare July 11, 2023 13:22
@ijsong ijsong force-pushed the telemetry_flags branch from ac82770 to ef95103 Compare July 11, 2023 13:22
@ijsong ijsong force-pushed the bump_opentelemetry branch from f38a9a1 to 2e6cc36 Compare July 18, 2023 14:44
@ijsong ijsong force-pushed the telemetry_flags branch from ef95103 to fd62edb Compare July 18, 2023 14:44
@ijsong ijsong force-pushed the bump_opentelemetry branch from 2e6cc36 to 5dc4fb0 Compare July 28, 2023 03:01
@ijsong ijsong force-pushed the telemetry_flags branch from fd62edb to fcacd1a Compare July 28, 2023 03:01
@ijsong
Copy link
Copy Markdown
Member Author

ijsong commented Jul 28, 2023

@ijsong started a stack merge that includes this pull request via Graphite.

Base automatically changed from bump_opentelemetry to main July 28, 2023 03:48
@ijsong ijsong merged commit 63355e9 into main Jul 28, 2023
@ijsong ijsong deleted the telemetry_flags branch July 28, 2023 03:49
@ijsong
Copy link
Copy Markdown
Member Author

ijsong commented Jul 28, 2023

@ijsong merged this pull request with Graphite.

ijsong added a commit that referenced this pull request Aug 7, 2023
🤖 I have created a release *beep* *boop*
---


## [0.15.0](v0.14.1...v0.15.0) (2023-07-31)


### Features

* **admin:** add otelgrpc metric interceptor ([d9ca9aa](d9ca9aa))
* **admin:** add otelgrpc metric interceptor ([#509](#509)) ([db7a1a2](db7a1a2))
* **admin:** speed up fetching cluster metadata ([3e46f62](3e46f62))
* **admin:** speed up fetching cluster metadata ([#480](#480)) ([53a8f19](53a8f19))
* **all:** add common flags for telemetry ([fcacd1a](fcacd1a))
* **all:** add common flags for telemetry ([#494](#494)) ([63355e9](63355e9))
* **benchmark:** share a connection between appenders in a target ([7dc53e9](7dc53e9))
* **benchmark:** share a connection between appenders in a target ([#524](#524)) ([2cd9196](2cd9196))
* **client:** add Clear to the log stream appender manager ([9a89065](9a89065))
* **client:** add Clear to the log stream appender manager ([#514](#514)) ([e5b6a2e](e5b6a2e))
* **storagenode:** add --storage-trim-delay to set a delay before the deletion of log entries ([db39713](db39713))
* **storagenode:** add --storage-trim-delay to set a delay before the deletion of log entries ([#529](#529)) ([015bfa4](015bfa4))
* **storagenode:** add --storage-trim-rate to set throttling rate of Trim ([83b7496](83b7496))
* **storagenode:** add --storage-trim-rate to set throttling rate of Trim ([#530](#530)) ([6e69306](6e69306))
* **telemetry:** customize bucket size of process.runtime.go.gc.pause_ns ([b181132](b181132))
* **telemetry:** customize bucket size of process.runtime.go.gc.pause_ns ([#510](#510)) ([9d99520](9d99520))
* **telemetry:** customize bucket size of rpc.server.duration ([a0e5973](a0e5973))
* **telemetry:** customize bucket size of rpc.server.duration ([#511](#511)) ([e41fe1c](e41fe1c))


### Bug Fixes

* **benchmark:** make append duration's precision high ([e3a091d](e3a091d))
* **benchmark:** make append duration's precision high ([#522](#522)) ([815af53](815af53))
* **benchmark:** support graceful stop ([8616d55](8616d55))
* **benchmark:** support graceful stop ([#527](#527)) ([fc4ed81](fc4ed81))
* **metarepos:** add TestMRIgnoreDirtyReport ([fe2a550](fe2a550))
* **metarepos:** allow set commitTick ([bdca20a](bdca20a))
* **metarepos:** ignore invalid report ([e8620de](e8620de))
* **storagenode:** ignore context error while checking to interleave of Append RPC errors ([04d1052](04d1052))
* **storagenode:** ignore context error while checking to interleave of Append RPC errors ([#504](#504)) ([5a7a3b0](5a7a3b0))
* **storagenode:** restore uncommitted logs ([267cccc](267cccc)), closes [#490](#490)
* **storagenode:** restore uncommitted logs ([#492](#492)) ([a9832ee](a9832ee)), closes [#490](#490)


### Performance Improvements

* **admin:** use singleflight to handle Admin's RPCs ([c231888](c231888))
* **admin:** use singleflight to handle Admin's RPCs ([#482](#482)) ([1a6a96d](1a6a96d))
* **metarepos:** add a pool for []*mrpb.Report ([fa8c89d](fa8c89d))
* **metarepos:** add a pool for []*mrpb.Report ([#534](#534)) ([16b2181](16b2181))
* **metarepos:** add a pool for *mrpb.RaftEntry ([be9f121](be9f121))
* **metarepos:** add a pool for *mrpb.RaftEntry ([#536](#536)) ([96ab5e2](96ab5e2))
* **metarepos:** add a pool for mrpb.Reports ([59a6a5a](59a6a5a))
* **metarepos:** add a pool for mrpb.Reports ([#533](#533)) ([b227c75](b227c75))
* **metarepos:** avoid copy overhead by removing unnecessary converting from byte slice to string ([a775628](a775628))
* **metarepos:** avoid copy overhead by removing unnecessary converting from byte slice to string ([#532](#532)) ([1702769](1702769))
* **metarepos:** reuse mrpb.StorageNodeUncommitReport while changed ([57d8039](57d8039))
* **metarepos:** reuse mrpb.StorageNodeUncommitReport while changed ([#537](#537)) ([8f6e097](8f6e097))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants