Skip to content

feat(admin): add a new flag replica-selector to the varlogadm#402

Merged
ijsong merged 1 commit intomainfrom
flag_repsel
Apr 8, 2023
Merged

feat(admin): add a new flag replica-selector to the varlogadm#402
ijsong merged 1 commit intomainfrom
flag_repsel

Conversation

@ijsong
Copy link
Copy Markdown
Member

@ijsong ijsong commented Apr 6, 2023

What this PR does

It added a new flag, replica-selector, to the varlogadm. The flag sets the global default replica
selector.

Which issue(s) this PR resolves

Updates #393

@ijsong ijsong requested a review from hungryjang as a code owner April 6, 2023 01:56
This was referenced Apr 6, 2023
Merged
Merged
Merged
@ijsong
Copy link
Copy Markdown
Member Author

ijsong commented Apr 6, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@ijsong ijsong mentioned this pull request Apr 6, 2023
Closed
6 tasks
@ijsong ijsong linked an issue Apr 6, 2023 that may be closed by this pull request
admin: methods to select replicas for log stream #393
Closed
6 tasks
@github-advanced-security
Copy link
Copy Markdown

github-advanced-security bot commented Apr 6, 2023

You have successfully added a new CodeQL configuration .github/workflows/codeql.yml:analyze/language:python. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@github-advanced-security
Copy link
Copy Markdown

github-advanced-security bot commented Apr 6, 2023

You have successfully added a new CodeQL configuration .github/workflows/codeql.yml:analyze/language:go. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@ijsong ijsong self-assigned this Apr 6, 2023
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 6, 2023 •
edited
Loading

Codecov Report

Patch coverage: 42.85% and no project coverage change.

Comparison is base (1892ae9) 63.58% compared to head (805f8de) 63.59%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #402   +/-   ##
=======================================
  Coverage   63.58%   63.59%           
=======================================
  Files         131      131           
  Lines       17793    17801    +8     
=======================================
+ Hits        11314    11320    +6     
- Misses       5934     5935    +1     
- Partials      545      546    +1
Impacted Files Coverage Δ
internal/admin/admin.go 61.30% <0.00%> (-0.57%) ⬇️
internal/admin/config.go 85.85% <100.00%> (ø)
internal/admin/replica_selector.go 95.74% <100.00%> (ø)

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ijsong ijsong force-pushed the lfu_replica_selector branch from 690b414 to 0e08901 Compare April 6, 2023 02:43
Base automatically changed from lfu_replica_selector to main April 6, 2023 03:29
@ijsong
feat(admin): add a new flag replica-selector to the varlogadm
805f8de 
It added a new flag, `replica-selector`, to the varlogadm. The flag sets the global default replica
selector.

Updates #393
@ijsong ijsong merged commit b03f08b into main Apr 8, 2023
@ijsong ijsong deleted the flag_repsel branch April 8, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hungryjang hungryjang hungryjang approved these changes

Assignees

@ijsong ijsong

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

admin: methods to select replicas for log stream

4 participants

@ijsong @github-advanced-security @codecov-commenter @hungryjang