feat(admin): add a name to the replica selector#394
Merged
Conversation
Member
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
This was referenced Apr 5, 2023
6 tasks
6 tasks
hungryjang
approved these changes
Apr 5, 2023
71dfc04 to
4328e61
Compare
It adds a new method `Name() string` to the replica selector interface `internal/admin.(ReplicaSelector)`. We can set a unique name for each replica selector, and therefore, we can use a necessary replica selection algorithm by specifying the name. Updates #393
4328e61 to
6e7e74f
Compare
Member
Author
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
It adds a new method
Name() stringto the replica selector interfaceinternal/admin.(ReplicaSelector). We can set a unique name for each replica selector, andtherefore, we can use a necessary replica selection algorithm by specifying the name.
Which issue(s) this PR resolves
Updates #393