Skip to content

feat(admin): random replica selector#395

Merged
ijsong merged 1 commit intomainfrom
random_replica_selector
Apr 6, 2023
Merged

feat(admin): random replica selector#395
ijsong merged 1 commit intomainfrom
random_replica_selector

Conversation

@ijsong
Copy link
Copy Markdown
Member

@ijsong ijsong commented Apr 5, 2023

What this PR does

It adds a new replica selector, randomReplicaSelector. It chooses storage nodes and paths
randomly.

Which issue(s) this PR resolves

Updates #393

@ijsong ijsong requested a review from hungryjang as a code owner April 5, 2023 09:54
@ijsong ijsong mentioned this pull request Apr 5, 2023
Merged
@ijsong
Copy link
Copy Markdown
Member Author

ijsong commented Apr 5, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@ijsong ijsong mentioned this pull request Apr 5, 2023
Merged
@ijsong ijsong self-assigned this Apr 5, 2023
@github-advanced-security
Copy link
Copy Markdown

github-advanced-security bot commented Apr 5, 2023

You have successfully added a new CodeQL configuration .github/workflows/codeql.yml:analyze/language:python. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@ijsong ijsong mentioned this pull request Apr 5, 2023
Closed
6 tasks
@ijsong ijsong linked an issue Apr 5, 2023 that may be closed by this pull request
admin: methods to select replicas for log stream #393
Closed
6 tasks
@github-advanced-security
Copy link
Copy Markdown

github-advanced-security bot commented Apr 5, 2023

You have successfully added a new CodeQL configuration .github/workflows/codeql.yml:analyze/language:go. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 5, 2023 •
edited
Loading

Codecov Report

Patch coverage: 91.17% and project coverage change: +0.03 🎉

Comparison is base (6e7e74f) 63.58% compared to head (ad1226e) 63.61%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@                    Coverage Diff                    @@
##           replica_selector_name     #395      +/-   ##
=========================================================
+ Coverage                  63.58%   63.61%   +0.03%     
=========================================================
  Files                        131      131              
  Lines                      17738    17772      +34     
=========================================================
+ Hits                       11279    11306      +27     
- Misses                      5920     5925       +5     
- Partials                     539      541       +2
Impacted Files Coverage Δ
internal/admin/replica_selector.go 90.00% <91.17%> (+7.44%) ⬆️

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ijsong ijsong force-pushed the replica_selector_name branch from 71dfc04 to 4328e61 Compare April 6, 2023 01:56
@ijsong ijsong force-pushed the random_replica_selector branch from bbfd462 to 93b86ff Compare April 6, 2023 01:56
@ijsong ijsong mentioned this pull request Apr 6, 2023
Merged
@ijsong
feat(admin): random replica selector
ad1226e 
It adds a new replica selector, `randomReplicaSelector`. It chooses storage nodes and paths
randomly.

Updates #393
@ijsong ijsong force-pushed the replica_selector_name branch from 4328e61 to 6e7e74f Compare April 6, 2023 02:43
@ijsong ijsong force-pushed the random_replica_selector branch from 93b86ff to ad1226e Compare April 6, 2023 02:43
@ijsong
Copy link
Copy Markdown
Member Author

ijsong commented Apr 6, 2023

@ijsong queued this pull request to merge with Graphite.

Base automatically changed from replica_selector_name to main April 6, 2023 03:28
@ijsong ijsong merged commit 8a09379 into main Apr 6, 2023
@ijsong ijsong deleted the random_replica_selector branch April 6, 2023 03:29
@ijsong
Copy link
Copy Markdown
Member Author

ijsong commented Apr 6, 2023

@ijsong merged this pull request with Graphite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hungryjang hungryjang hungryjang approved these changes

Assignees

@ijsong ijsong

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

admin: methods to select replicas for log stream

4 participants

@ijsong @github-advanced-security @codecov-commenter @hungryjang