Routing: New URL routing for Joomla by Hackwar · Pull Request #8256 · joomla/joomla-cms

Hackwar · 2015-11-03T10:07:48Z

This is an updated PR from #7615

This PR implements a new routing system for Joomla, based on what has been proposed here: http://www.joomlager.de/crowdfunding

This is a combined PR of the former changes from #5446, #5501, #5502. #5503, #5509, #5599 and #5604.

Please test and comment. For further informations, read the other 7 PRs.

…omponentrouteradvanced

…ms into componentrulesitemid

…omponentrouteradvanced

…ms into componentrulesitemid

https://travis-ci.org/joomla/joomla-cms/jobs/44966357

Fix CS issues that was found by Travis

…s pretty complex and throws errors in our testing environment

…into com_content_router_legacy

…-cms into com_content_router_legacy

…omponentrouteradvanced

…iews in JComponentRouterAdvanced

…omponentrouteradvanced

…lasses except for JComponentRouterAdvanced

…ng unittests for JComponentRouterAdvanced

…ms into componentrulesitemid

joomla-cms-bot · 2016-01-07T12:40:24Z

This PR has received new commits.

CC: @anibalsanchez, @Gitjk

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8256.}

joomla-cms-bot · 2016-01-07T12:47:47Z

This PR has received new commits.

CC: @anibalsanchez, @Gitjk

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8256.}

joomla-cms-bot · 2016-01-07T13:03:29Z

This PR has received new commits.

CC: @anibalsanchez, @Gitjk

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8256.}

joomla-cms-bot · 2016-01-07T13:23:53Z

This PR has received new commits.

CC: @anibalsanchez, @Gitjk

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8256.}

joomla-cms-bot · 2016-01-07T13:30:15Z

This PR has received new commits.

CC: @anibalsanchez, @Gitjk

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8256.}

Hackwar · 2016-01-08T19:52:26Z

Hi folks, I cleaned up the code further, fixed the unittests and fixed the codestyle. Please give this another round of tests.

To test, please apply these changes and enable the new routing in the global configuration. Then check the URLs of the site. The best would be, if you could test this on a copy of a real site. The sampledata of Joomla has already been tested and works. When you test these changes, the URLs should stay the same in most cases. The only time when the URL will be changed by this is when the menu item links to a category and the content item is in a child-child-category of the linked category.

Gitjk · 2016-01-08T22:01:37Z

Hi again,
Just had a short (10 Minute) look. Used latest staging Joomla and VirtueMart 3.0.12, both bilingual. After adding #8256 with the patch-tester, I didn't see any difference in urls with 'Use new URL routing' enabled/disabled. Seems to work fine at the first glance. I might have another look on Sunday.

infograf768 · 2016-01-09T09:05:31Z

@test
Looks like working fine here on my multilingual test site, sef on.
Did not test the child-child situation yet.

infograf768 · 2016-01-09T09:30:06Z

Please alpha order new lang strings.

brianteeman · 2016-01-09T09:46:05Z

administrator/language/en-GB/en-GB.com_config.ini

will or may?

You are right, it "may" change your URLs.

anibalsanchez · 2016-01-09T14:31:05Z

Tested on a news site, upgraded to Joomla 3.5, installed the new router, crawled Urls with Screaming Frog and compared results. No differences found in resulting Urls.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8256.}

wilsonge · 2016-01-28T21:26:20Z

@Hackwar can you please update this PR to staging (conflicts atm). Got some more people to test on this

Conflicts: components/com_content/router.php

joomla-cms-bot · 2016-01-29T08:57:13Z

This PR has received new commits.

CC: @anibalsanchez, @Gitjk

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8256.}

joomla-cms-bot · 2016-01-29T08:59:56Z

This PR has received new commits.

CC: @anibalsanchez, @Gitjk

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8256.}

Hackwar · 2016-01-29T09:01:16Z

I've updated the branch. Please notice that I've moved the setting for advanced routing from the global configuration to the component configuration for each specific component.

Fixes #8256

wilsonge · 2016-02-20T18:15:17Z

Merged into 3.6.x branch :)

810 · 2016-10-05T01:21:13Z

UsersHelperRoute::getLoginRoute(); is set to deprecated, what's the new call, or are the deprecated tags wrong on the j3.6/7 branch, because on the 4.0 branch its still there

wilsonge · 2016-10-05T03:52:39Z

4.0 branch is currently based on staging not the 3.7 branch :)

Hackwar and others added 30 commits December 16, 2014 16:51

Implementing JComponentRouterAdvanced class

56e680e

Merge branch 'staging' of https://github.com/joomla/joomla-cms into c…

3b80c54

…omponentrouteradvanced

Implementing JComponentRouterRulesMenu class to find right Itemid

4082a78

Call-time pass-by-reference has been removed

72cd9e0

Merge branch 'componentrouteradvanced' of github.com:Hackwar/joomla-c…

62a056b

…ms into componentrulesitemid

Removing JError, using Exception instead

ea8ea8a

protecting $name and renaming register() to registerView()

de17a6b

Codestyle and minor bug

e3f6963

Merge branch 'staging' of https://github.com/joomla/joomla-cms into c…

b3c81bb

…omponentrouteradvanced

Adding removeRule, getRules and renamed $id to $key in register method

0309e22

Merge branch 'componentrouteradvanced' of github.com:Hackwar/joomla-c…

fd05703

…ms into componentrulesitemid

Implementing legacy router for com_content

fc9ef1c

Codestylefix

2400973

Implementing legacy router for com_contact

66fcdf8

Fix CS issues that was found by Travis

6ec059f

https://travis-ci.org/joomla/joomla-cms/jobs/44966357

Merge pull request #14 from zero-24/patch-25

c78284e

Fix CS issues that was found by Travis

Implementing legacy router for com_newsfeeds

dc9203b

Codestyle

ca445dd

Codestyle

6e9171e

Implementing legacy router for com_users

273a6c9

Changing component router to retrieve, since the com_content router i…

6f89554

…s pretty complex and throws errors in our testing environment

Merge branch 'componentrulesitemid' of github.com:Hackwar/joomla-cms …

e1333f3

…into com_content_router_legacy

Merge branch 'com_content_router_legacy' of github.com:Hackwar/joomla…

c321259

…-cms into com_content_router_legacy

Making method names consistent

8d17e7a

Merge branch 'staging' of https://github.com/joomla/joomla-cms into c…

f0f5d5f

…omponentrouteradvanced

Implementing JComponentRouterViewconfiguration for configuration of v…

68d9424

…iews in JComponentRouterAdvanced

Merge branch 'staging' of https://github.com/joomla/joomla-cms into c…

dacdc2e

…omponentrouteradvanced

Codestyle, smaller improvements, unittests for all component router c…

260a007

…lasses except for JComponentRouterAdvanced

Removing ability to have one view with different names and implementi…

0133947

…ng unittests for JComponentRouterAdvanced

Merge branch 'componentrouteradvanced' of github.com:Hackwar/joomla-c…

a677ef3

…ms into componentrulesitemid

Fixing unittest for PHP7

7437ff4

Codestyle

65b2e4d

Codestyle

2d02fb3

Codestyle ... again

e276f16

brianteeman reviewed Jan 9, 2016
View reviewed changes

Hackwar added 2 commits January 29, 2016 09:54

Implementing component specific advanced routing setting

3168a82

Merge branch 'staging' of github.com:joomla/joomla-cms into routing

5fe5cdb

Conflicts: components/com_content/router.php

Reverting erronous commit

a846762

wilsonge pushed a commit that referenced this pull request Feb 20, 2016

New URL Routing!

272c1b0

Fixes #8256

wilsonge closed this Feb 20, 2016

wilsonge modified the milestones: Joomla 3.7.0, Joomla 3.6.0 May 11, 2016

Hackwar deleted the routing branch April 27, 2019 07:48

Uh oh!

Conversation

Hackwar commented Nov 3, 2015

Uh oh!

joomla-cms-bot commented Jan 7, 2016

Uh oh!

joomla-cms-bot commented Jan 7, 2016

Uh oh!

joomla-cms-bot commented Jan 7, 2016

Uh oh!

joomla-cms-bot commented Jan 7, 2016

Uh oh!

joomla-cms-bot commented Jan 7, 2016

Uh oh!

Hackwar commented Jan 8, 2016

Uh oh!

Gitjk commented Jan 8, 2016

Uh oh!

infograf768 commented Jan 9, 2016

Uh oh!

infograf768 commented Jan 9, 2016

Uh oh!

brianteeman Jan 9, 2016

Choose a reason for hiding this comment

Uh oh!

Hackwar Jan 9, 2016

Choose a reason for hiding this comment

Uh oh!

anibalsanchez commented Jan 9, 2016

Uh oh!

wilsonge commented Jan 28, 2016

Uh oh!

joomla-cms-bot commented Jan 29, 2016

Uh oh!

joomla-cms-bot commented Jan 29, 2016

Uh oh!

Hackwar commented Jan 29, 2016

Uh oh!

wilsonge commented Feb 20, 2016

Uh oh!

810 commented Oct 5, 2016

Uh oh!

wilsonge commented Oct 5, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants