Routing: No-Itemid-behavior for components#5599
Closed
Hackwar wants to merge 55 commits intojoomla:stagingfrom
Closed
Routing: No-Itemid-behavior for components#5599Hackwar wants to merge 55 commits intojoomla:stagingfrom
Hackwar wants to merge 55 commits intojoomla:stagingfrom
Conversation
…omponentrouteradvanced
…ms into componentrulesitemid
…omponentrouteradvanced
…ms into componentrulesitemid
…s pretty complex and throws errors in our testing environment
…omponentrouteradvanced
…iews in JComponentRouterAdvanced
…omponentrouteradvanced
…lasses except for JComponentRouterAdvanced
…ng unittests for JComponentRouterAdvanced
…ms into componentrulesitemid
…omponentrouteradvanced
…ms into componentrulesitemid
Call-time pass-by-reference has been removed Removing JError, using Exception instead protecting $name and renaming register() to registerView() Adding removeRule, getRules and renamed $id to $key in register method Making method names consistent Implementing JComponentRouterViewconfiguration for configuration of views in JComponentRouterAdvanced Codestyle, smaller improvements, unittests for all component router classes except for JComponentRouterAdvanced Removing ability to have one view with different names and implementing unittests for JComponentRouterAdvanced Adding get<View>Slug() and get<View>Key() methods to JComponentRouterAdvanced Updating unittest Small fixes Adding back in platform check Adding back in platform check Adding back in platform check Adding back in platform check Implementing feedback so far Adding "covers" notation for unittests
…omponentrulesitemid Conflicts: tests/unit/suites/libraries/cms/component/router/JComponentRouterViewTest.php
PHP7 fixes
Fix unit test failure in JComponentRouterViewTest
…omponentrulesitemid
…omponentrulesitemid
…into componentrulesnomenu2
Member
Author
|
I've updated this PR to work with the changed JComponentRouterView class. Please test. |
Contributor
|
Is this still active? If so, I suggest a companion PR with patch for the listed code changes needed to implement the test conditions. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5599. |
Member
Author
|
@Duke3D What do you mean with companion PR and what not? And this is still active, yes. |
Member
Author
|
Please be aware that all comments above mine from May 23rd have either been incorporated into this or do not apply here. Those come from several cross merges. |
Member
Author
|
I've combined the changes from this and all other routing related PRs into a new PR: #7615 Please review and comment in the new PR. I'm closing this one, so that we can focuse on the new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a rule for URLs with missing Itemid as a generic rule for all component routers that extend from JComponentRouterView.
How to test
with
This was updated on May 22nd 2015. All discussions prior to that point have either been integrated or are obsolete.
This was made possible through the generous donation of the people mentioned in the following link via an Indiegogo campaign: http://joomlager.de/crowdfunding/5-contributors