Routing: Legacy Router Rule for com_users#5509
Closed
Hackwar wants to merge 57 commits intojoomla:stagingfrom
Closed
Routing: Legacy Router Rule for com_users#5509Hackwar wants to merge 57 commits intojoomla:stagingfrom
Hackwar wants to merge 57 commits intojoomla:stagingfrom
Conversation
…omponentrouteradvanced
…ms into componentrulesitemid
…omponentrouteradvanced
…ms into componentrulesitemid
…s pretty complex and throws errors in our testing environment
…omponentrouteradvanced
…iews in JComponentRouterAdvanced
…omponentrouteradvanced
…lasses except for JComponentRouterAdvanced
…ng unittests for JComponentRouterAdvanced
…ms into componentrulesitemid
…into com_users_router_legacy
…omponentrouteradvanced
…ms into componentrouteradvanced
…omponentrulesitemid
…omponentrouteradvanced
…ms into componentrulesitemid
Call-time pass-by-reference has been removed Removing JError, using Exception instead protecting $name and renaming register() to registerView() Adding removeRule, getRules and renamed $id to $key in register method Making method names consistent Implementing JComponentRouterViewconfiguration for configuration of views in JComponentRouterAdvanced Codestyle, smaller improvements, unittests for all component router classes except for JComponentRouterAdvanced Removing ability to have one view with different names and implementing unittests for JComponentRouterAdvanced Adding get<View>Slug() and get<View>Key() methods to JComponentRouterAdvanced Updating unittest Small fixes Adding back in platform check Adding back in platform check Adding back in platform check Adding back in platform check Implementing feedback so far Adding "covers" notation for unittests
…omponentrulesitemid Conflicts: tests/unit/suites/libraries/cms/component/router/JComponentRouterViewTest.php
PHP7 fixes
Fix unit test failure in JComponentRouterViewTest
…omponentrulesitemid
…omponentrulesitemid
…into com_users_router_legacy
…ponentRouterAdvanced
Member
Author
|
I've combined the changes from this and all other routing related PRs into a new PR: #7615 Please review and comment in the new PR. I'm closing this one, so that we can focuse on the new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the current routers behavior of com_users as a legacyrouter. This is meant for those that want to keep the old behavior at all costs. Later, parameters will be introduced to switch between the legacy behavior and new features.
This router is copied verbatim from the current router to make sure that the same behavior is kept. No changes should be done to it until Joomla 4.0, when this is supposed to be deleted. The component routers right now are so fragile, that a slow transition will be next to impossible. To prevent any breaks in backwards compatibility, this legacy router is introduced, so that people having problems with the new router can switch back.
How to test
Dependencies
This PR requires #5446 to be accepted by the project before it can be applied.
This was made possible through the generous donation of the people mentioned in the following link via an Indiegogo campaign: http://joomlager.de/crowdfunding/5-contributors