Preview: Video

tested. Works fine. But I'm getting Unexpected token '}'

@losedk I get that as well also on statistics. There must be something with the modal code but is not related with this PR

@DGT41 Ahh yeah, just spotted that!

Well the PR is fine then :)

Latest commit adds one more progress bar (orange) for the optimize process (follows after indexing)

I get a javascript error. Please see the screenshot.

@waader please clear your browsers cache

Better now, but I get these errors:

And one small suggestion: maybe it would be more clear that the optimizing is done if some sort of checkmark would be display. Currently you have the orange bar with only the text that says the process is done. But users don´t read.

@waader for the joomla.toggleSidebar check #5259
I guess we can add some icons there, but just to remind you that the previous version didn’t have 2nd progress bar at all, it was just the text message

@test works!

I applied also #5259 and the ReferenceError has gone. I am aware of the new 2nd progress bar. I made the suggestion because it is animated and when you only watch this hypnotizing animation you could get the impression that the process isn´t done.

@waader what would be nice, I think, is to have a close button (green) at the end! And maybe remove the ability to close the modal and also remove the x icon on the top right corner

Well, that would be much better.

@waader at the end of the optimization process, the progress bar is removed, right?

@test success, however I got a couple of JS errors:

• SyntaxError: syntax error
  ator/index.php?option=com_finder&view=indexer&tmpl=component
  index.p...w=index (line 1, col 60)

The button has an Url in onClick button: https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_finder/views/index/view.html.php#L73

• ReferenceError: Joomla is not defined template.js (line 60)
  Joomla.toggleSidebar = function(force)

This one seems unrelated with the finder.

Thanks @anibalsanchez! For the second error there is a solution: #5259. The first one is related to bootstrap modal (?) or toolbar button (?). Trying to find the root of the problem there, but still I have no success. If you have any idea what is wrong please make a PR to get rid of that..

@DGT41 The modal problem is related with the onclick, it has an Url intead of Javascript code.... but it works... very odd indeed.

@anibalsanchez but according to this the code seems fine (?)

Here _getCommand according to the description should return a Javascript command, but it returns just the URL: https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/toolbar/button/popup.php#L115 ... that it's assigned to the onClick.

@anibalsanchez you’ll do a PR for that?

@DGT41 Sure ... but I don't know what it should return, Bootstrap modal does not need any onClick

It seems that bootstrap all it needs is a url for the iframe: https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/html/bootstrap.php#L319

@DGT41 the problem is in the toolbar button, where the Url is inserted as a command

https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/toolbar/button/popup.php#L59
https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/toolbar/button/popup.php#L65

@anibalsanchez The easiest solution is to change onclick with value in the layout: https://github.com/joomla/joomla-cms/blob/staging/layouts/joomla/toolbar/popup.php#L19

@anibalsanchez check #5420

Moving to RTC since we have 2 successful tests.

@DGT41 The progress bar is not removed as you can see from the screenshot. I tested with current staging branch and "test sample data".

@waader This PR removes the internal dependency with mootools (behavior.framework). It does not change how the progressbar works now, for example, it does not auto-close it at the end.

@anibalsanchez The progress bar for the optimization is new and the behaviour is different when I test with the default data sample versus test with the test data sample. With the default sample the progress bar disappears when optimization is done, with the test data sample it stays.

@waader since I can’t reproduce this can you replace line 88 of indexer.js with

        if (progress >= 200) {

and report the results?
PS it has to be >=

When optimizing is done progress has a value of 109.09090909090908. >= 100 would help.

@waader Yes you are right, I just tested that.
The solution is quite simple:
in indexer.js line 88 has to be:

        if (message == msg) {

And we have to add in views/indexer/tmpl/default.php

JHtml::_('behavior.core');
JFactory::getDocument()->addScriptDeclaration('var msg = "' . JText::_('COM_FINDER_INDEXER_MESSAGE_COMPLETE') . '"');

before line 15

@waader check #5433