Eliminates minor javascript error in toolbar popup button#5420
Merged
roland-d merged 1 commit intojoomla:stagingfrom Dec 14, 2014
dgrammatiko:_toolbar_popup_error
Merged
Eliminates minor javascript error in toolbar popup button#5420roland-d merged 1 commit intojoomla:stagingfrom dgrammatiko:_toolbar_popup_error
roland-d merged 1 commit intojoomla:stagingfrom
dgrammatiko:_toolbar_popup_error
Conversation
Contributor
|
@test all good and fixes also a JS error on the banner tracks export. |
Contributor
|
Moving to RTC, we have 2 successful tests. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5420. |
roland-d
added a commit
that referenced
this pull request
Dec 14, 2014
Eliminates minor javascript error in toolbar popup button
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whenever a modal is render through a toolbar popup button, an error is logged in the browser.
This is due to
onClickbeen set as Url.This PR changes
onclickto value (acceptable option for buttons)Testing
Apply #5386
There are two javascript errors logged in your browsers console (the second one
Joomla.toggleSidebaris solved #5259)Apply this PR
error should go away