Remove optimization bar at the end of the process#5433
Merged
roland-d merged 1 commit intojoomla:stagingfrom Dec 15, 2014
dgrammatiko:indexer_progressbar
Merged
Remove optimization bar at the end of the process#5433roland-d merged 1 commit intojoomla:stagingfrom dgrammatiko:indexer_progressbar
roland-d merged 1 commit intojoomla:stagingfrom
dgrammatiko:indexer_progressbar
Conversation
Contributor
|
@test success, dialog is auto-closed. |
Contributor
|
@test success! Thanks! |
Contributor
|
@DGT41 When I run the indexer I get this error using Firefox on a Mac: |
Contributor
Author
|
@roland-d You have to clear the cache. The new indexer.js doesn’t have |
Contributor
|
@DGT41 Thanks, I did try to clear the FF cache but it is being stubborn :) Just wanted to be sure it was a local issue as I did get it to work on Safari. |
Contributor
Author
|
@roland-d I am using an addon: Clear Cache Button in FF. Makes life a little easier 😉 |
Contributor
|
moving to RTC Thanks to all! This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5433. |
Contributor
roland-d
added a commit
that referenced
this pull request
Dec 15, 2014
Remove optimization bar at the end of the process
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new progress bar that appears in optimization process might not disappear at the end of the process
This fixes an anomaly discovered by @waader at #5386
Test
Install joomla with test data (staging)
run finder indexer
At the end of the process the optimization bar doesn’t disappear
Apply this patch
Purge and re index
Yellow bar disappears at the end of the process