Skip to content

[5.1] Unification patch for PR #42610#42663

Merged
LadySolveig merged 1 commit intojoomla:5.1-devfrom
tecpromotion:patch-pr-42610
Jan 17, 2024
Merged

[5.1] Unification patch for PR #42610#42663
LadySolveig merged 1 commit intojoomla:5.1-devfrom
tecpromotion:patch-pr-42610

Conversation

@tecpromotion
Copy link
Copy Markdown
Contributor

Summary of Changes

This small patch standardises the spelling for occurrences of "_MANAGE_LANGUAGES_CONTENT"

See

MOD_MENU_MANAGE_LANGUAGES_CONTENT="Content Languages"

and
COM_INSTALLER_TOOLBAR_MANAGE_CONTENT_LANGUAGES="Content Languages"

Testing Instructions

code review

Actual result BEFORE applying this Pull Request

Two notations for two equivalent constants.

Expected result AFTER applying this Pull Request

Standardised spelling

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@heelc29
Copy link
Copy Markdown
Contributor

heelc29 commented Jan 17, 2024

I have tested this item ✅ successfully on 75eb4ee


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42663.

@brianteeman
Copy link
Copy Markdown
Contributor

Unfortunately you can nont do this https://developer.joomla.org/development-strategy.html

Changing or deleting a language key is considered a backwards compatibility break. Adding new ones is not. Substantially changing the meaning associated with a language key is a compatibility break. Rephrasing something for a more accurate description or proper en-GB grammar is not.

@heelc29
Copy link
Copy Markdown
Contributor

heelc29 commented Jan 17, 2024

@brianteeman The language string (COM_INSTALLER_TOOLBAR_MANAGE_CONTENT_LANGUAGES) you mean was added yesterday with #42610 and is not yet included in any public release -> so it should be ok.

@brianteeman
Copy link
Copy Markdown
Contributor

ok then

@LadySolveig LadySolveig merged commit e0489cd into joomla:5.1-dev Jan 17, 2024
@LadySolveig
Copy link
Copy Markdown
Contributor

Thank you @tecpromotion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants