[5.1] Workflows missing strings#42390
Merged
Razzo1987 merged 4 commits intojoomla:5.1-devfrom Nov 30, 2023
Merged
Conversation
AFAICT these strings have been missing since the beginning. They are used in administrator/components\com_workflow\src\Controller\StagesController.php administrator/components\com_workflow\src\Controller\TransitionController.php administrator/components\com_workflow\src\Controller\WorkflowsController.php This has been made against 5.1 as they are new strings
Contributor
|
I have tested this item ✅ successfully on 0d632fc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42390. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 0d632fc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42390. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42390. |
Contributor
|
Thank you! |
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Feb 24, 2024
joomla/joomla-cms#42220 - (только для en-GB) joomla/joomla-cms#37320 + joomla/joomla-cms#42390 + joomla/joomla-cms#42393 + joomla/joomla-cms#42584 + joomla/joomla-cms#42607 + joomla/joomla-cms#42402 + joomla/joomla-cms#42334 + joomla/joomla-cms#42610 + joomla/joomla-cms#42663 + joomla/joomla-cms#42747 +
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AFAICT these strings have been missing since the beginning. They are used in
administrator/components\com_workflow\src\Controller\StagesController.php administrator/components\com_workflow\src\Controller\TransitionController.php administrator/components\com_workflow\src\Controller\WorkflowsController.php
This has been made against 5.1 as they are new strings
Testing Instructions
code review should be fine
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed