[5.1] Subform rows sorting with buttons, addittionaly to drag and drop#42334
Merged
LadySolveig merged 15 commits intojoomla:5.1-devfrom Jan 12, 2024
Merged
[5.1] Subform rows sorting with buttons, addittionaly to drag and drop#42334LadySolveig merged 15 commits intojoomla:5.1-devfrom
LadySolveig merged 15 commits intojoomla:5.1-devfrom
Conversation
Contributor
|
I have tested this item ✅ successfully on 89a503e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42334. |
Contributor
|
This approach is a bit reductive and I don't feel like it fully addresses #39092. Dragging and dropping is still very bad, and I don't think adding an up and down arrow is enough to call the problem solved... |
Contributor
|
I have tested this item ✅ successfully on 89a503e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42334. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42334. |
Contributor
|
A heartfelt thanks @Fedik and thanks to the testers @viocassel @Quy |
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Feb 24, 2024
joomla/joomla-cms#42220 - (только для en-GB) joomla/joomla-cms#37320 + joomla/joomla-cms#42390 + joomla/joomla-cms#42393 + joomla/joomla-cms#42584 + joomla/joomla-cms#42607 + joomla/joomla-cms#42402 + joomla/joomla-cms#42334 + joomla/joomla-cms#42610 + joomla/joomla-cms#42663 + joomla/joomla-cms#42747 +
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Add posibility to sort subform rows with buttons "up" and "down".
Useful for large forms.
Fix for #39092
Testing Instructions
Run
npm installCreate a subform somewhere:
And use new up/down button for rows sorting
Actual result BEFORE applying this Pull Request
nothing
Expected result AFTER applying this Pull Request
works
Link to documentations
Please select: