User Profile Terms of service#38619
Merged
roland-d merged 3 commits intojoomla:4.2-devfrom Aug 31, 2022
Merged
Conversation
In the user profile plugin there is a Terms of Service field that is required on registration. It has an optional accompanying field to link to an article.
Contributor
|
I have tested this item ✅ successfully on 420ed1e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38619. |
Contributor
|
I have tested this item ✅ successfully on 420ed1e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38619. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38619. |
Quy
reviewed
Aug 28, 2022
Member
|
@Quy Does it need new tests? From my point of view RTC is still ok, I've just reviewed that last change. |
Contributor
|
It is not necessary as it is an obsolete variable. |
Contributor
|
Thank you |
Contributor
Author
|
thanks |
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Sep 2, 2022
joomla/joomla-cms#38638 + joomla/joomla-cms#38622 + joomla/joomla-cms#38619 + joomla/joomla-cms#38592 + joomla/joomla-cms#38541 - (только для en-GB) joomla/joomla-cms#38537 - (только для en-GB) joomla/joomla-cms#38570 + joomla/joomla-cms#38459 + joomla/joomla-cms#38451 + joomla/joomla-cms#38449 + joomla/joomla-cms#38313 + joomla/joomla-cms#38447 +
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the user profile plugin there is a Terms of Service field that is required on registration. It has an optional accompanying field to link to an article.
Pull Request for Issue #28537 .
Summary of Changes
Before this PR the logic for checking that a user had agreed to the terms of service was broken so thta if there is no linked article the cjeck is never performed and a user can still register even if they dont agree.
This PR removes the check for the existence of the article and tweaks the language string used in the error message accordingly
Testing Instructions
Actual result BEFORE applying this Pull Request
User created
Expected result AFTER applying this Pull Request
User not created and error message displayed