Template Override Description#38451
Merged
roland-d merged 7 commits intojoomla:4.2-devfrom Aug 31, 2022
Merged
Conversation
Adds an information message above the list of overrides to explain what they are
sandewt
reviewed
Aug 13, 2022
|
I have tested this item ✅ successfully on fe8326d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38451. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on fe8326d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38451. |
Member
|
@brianteeman Shall the dummy message be replaced by a real one with this PR? Or with another one? I thought I should ask before setting RTC. |
Member
|
@brianteeman Maybe you’ve missed my question above: #38451 (comment) |
Contributor
Author
|
Sorry I thought I had replied. I will update the description in the coming days. It's not a priority for me right now as it wont get merged for ages. |
richard67
reviewed
Aug 31, 2022
Member
|
RTC since the previous 2 human tests for the description text being shown are still valid. The change after that was just a replacement of the dummy text by a real one, which I just have reviewed. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38451. |
Contributor
|
Thank you |
Contributor
Author
|
thanks |
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Sep 2, 2022
joomla/joomla-cms#38638 + joomla/joomla-cms#38622 + joomla/joomla-cms#38619 + joomla/joomla-cms#38592 + joomla/joomla-cms#38541 - (только для en-GB) joomla/joomla-cms#38537 - (только для en-GB) joomla/joomla-cms#38570 + joomla/joomla-cms#38459 + joomla/joomla-cms#38451 + joomla/joomla-cms#38449 + joomla/joomla-cms#38313 + joomla/joomla-cms#38447 +
brianteeman
added a commit
to brianteeman/joomla-cms
that referenced
this pull request
Dec 1, 2022
This fixes a language string error in my own pr joomla#38451 Testing requires overrides that need checking. You can simulate this by 1. Create template overrides for com_content/article and com_newsfeed/feed 2. Run this sql query replacing #_ with your db prefix INSERT INTO `#__template_overrides` (`id`, `template`, `hash_id`, `extension_id`, `state`, `action`, `client_id`, `created_date`, `modified_date`) VALUES (1, 'cassiopeia', 'L2h0bWwvY29tX25ld3NmZWVkcy9uZXdzZmVlZC9kZWZhdWx0LnBocA==', 223, 0, 'Joomla Update', 0, '2022-09-01 13:51:54', '2022-09-01 13:51:54'), (2, 'cassiopeia', 'L2h0bWwvY29tX2NvbnRlbnQvYXJ0aWNsZS9kZWZhdWx0X2xpbmtzLnBocA==', 223, 0, 'Joomla Update', 0, '2022-09-01 13:51:54', '2022-09-01 13:51:54'); You will now have two override files to update and can test this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Add an information message above the list of changed files to explin what the list is and what you should d.
(The message in this pr is a dummy message - I am open to suggestions of the actual text)
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request