Merged
Conversation
Due to a bug in the way the parent group field was calculated it was not possible to rename the Public usergroup. Now you can.
This was referenced Aug 24, 2022
Contributor
|
I have tested this item ✅ successfully on a94a0d1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38592. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on a94a0d1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38592. |
Contributor
|
Thanks for this PR. As users can replace the name "public" now to "wrdlbrmpft", I think it is better to let the English defalt names for all languages also in future. It woul need rewriting lots of tutorials. |
Contributor
Author
|
If I ran a multlingual site I would definitely want my non-english speaking admins to be able to understand what the groups are. For people who use a different character set its even harder to understand - thats why I will make it multlingual translatable in a future pr. (just like workflows is) |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38592. |
tecpromotion
approved these changes
Aug 25, 2022
Contributor
|
Thank you |
Contributor
Author
|
thanks |
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Sep 2, 2022
joomla/joomla-cms#38638 + joomla/joomla-cms#38622 + joomla/joomla-cms#38619 + joomla/joomla-cms#38592 + joomla/joomla-cms#38541 - (только для en-GB) joomla/joomla-cms#38537 - (только для en-GB) joomla/joomla-cms#38570 + joomla/joomla-cms#38459 + joomla/joomla-cms#38451 + joomla/joomla-cms#38449 + joomla/joomla-cms#38313 + joomla/joomla-cms#38447 +
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #36322 .
Summary of Changes
Due to a bug in the way the parent group field was calculated it was not possible to rename the Public usergroup. Now you can.
Testing Instructions
Edit the public usergroep
Change the name
Save
Actual result BEFORE applying this Pull Request
Error: "Invalid field: Group Parent"
Expected result AFTER applying this Pull Request
New name is saved
Documentation Changes Required
Remove "The default groups should not be edited!" from the docs
Notes