Skip to content

Remove label from a hidden field#38255

Merged
roland-d merged 4 commits intojoomla:4.2-devfrom
chmst:categories-label-assetid
Jul 12, 2022
Merged

Remove label from a hidden field#38255
roland-d merged 4 commits intojoomla:4.2-devfrom
chmst:categories-label-assetid

Conversation

@chmst
Copy link
Copy Markdown
Contributor

@chmst chmst commented Jul 11, 2022

Pull Request for Issue # .

Summary of Changes

See title. There are no labels for hidden fields asset_id in the whole system except here.

Testing Instructions

Code review.

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Jul 11, 2022 •
edited
Loading

this is the correct one. the rest all result in accessibility errors

@chmst
Copy link
Copy Markdown
Contributor Author

chmst commented Jul 11, 2022

In my understanding hidden fields should not be accessible or announced.

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Jul 11, 2022

Sorry I was confusing with something else

@Fedik
Copy link
Copy Markdown
Member

Fedik commented Jul 11, 2022

I have tested this item ✅ successfully on 2d24733

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38255.

1 similar comment
@khu5h1
Copy link
Copy Markdown
Contributor

khu5h1 commented Jul 11, 2022

I have tested this item ✅ successfully on 2d24733

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38255.

@richard67
Copy link
Copy Markdown
Member

richard67 commented Jul 11, 2022

Shouldn't the language string be marked with a deprecated comment in the 2 language files "administrator/language/en-GB/joomla.ini" and "api/language/en-GB/joomla.ini" because it is not used anymore when this PR is applied?

@chmst
Copy link
Copy Markdown
Contributor Author

chmst commented Jul 11, 2022

If I understand this correctly, the Key is already deprecated https://github.com/joomla/joomla-cms/blob/4.2-dev/administrator/language/en-GB/joomla.ini#L210

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Jul 11, 2022

that comment applies to the next line only. not the resto of the file

@joomla-cms-bot joomla-cms-bot added the Language Change This is for Translators label Jul 11, 2022
@chmst
Copy link
Copy Markdown
Contributor Author

chmst commented Jul 11, 2022

Thanks - a misunderstanding

@richard67 richard67 removed the Language Change This is for Translators label Jul 11, 2022
@richard67
Copy link
Copy Markdown
Member

richard67 commented Jul 11, 2022

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38255.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 11, 2022
@richard67 richard67 added the Language Change This is for Translators label Jul 11, 2022
@roland-d roland-d merged commit 4c2d6e6 into joomla:4.2-dev Jul 12, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 12, 2022
@roland-d
Copy link
Copy Markdown
Contributor

roland-d commented Jul 12, 2022

Thank you

@roland-d roland-d added this to the Joomla! 4.2.0 milestone Jul 12, 2022
@jgerman-bot jgerman-bot mentioned this pull request Jul 13, 2022
Closed
@joomlapl-bot joomlapl-bot mentioned this pull request Jul 13, 2022
Closed
Kostelano added a commit to JPathRu/localisation that referenced this pull request Jul 19, 2022
@Kostelano
Новое в 4.2.0 rc1
66392d2 
joomla/joomla-cms#36749 +
joomla/joomla-cms#38228 +
joomla/joomla-cms#38227 - (только для en-GB, у нас исправлено ранее)
joomla/joomla-cms#38255 +
joomla/joomla-cms#38244 +
joomla/joomla-cms#38271 - (только для en-GB, у нас исправлено ранее)
joomla/joomla-cms#38287 - (только для en-GB, у нас исправлено ранее)
joomla/joomla-cms#38301 - (только для en-GB, у нас исправлено ранее)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Language Change This is for Translators

Projects

None yet

Milestone

Joomla! 4.2.0

Development

Successfully merging this pull request may close these issues.

7 participants

@chmst @brianteeman @Fedik @khu5h1 @richard67 @roland-d @joomla-cms-bot