[4.2] Menu item custom field#38244
Conversation
administrator/components/com_admin/sql/updates/mysql/4.2.0-2022-07-07.sql
Show resolved
Hide resolved
administrator/components/com_admin/sql/updates/postgresql/4.2.0-2022-07-07.sql
Outdated
Show resolved
Hide resolved
|
I have tested this item ✅ successfully on b304e06 Txs very much Brian for introducing this new Type of Custom Fields! Note for those who don't know: this follows a question I raised yesterday on the Joomla Facebook Group: https://www.facebook.com/groups/joomlanospam/posts/10158401801610997/ I have tested this successfully (on an existing J4.1 website). This new Type of Custom Fields can be useful in many cases. Txs again Brian for this (very) quick PR :) This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38244. |
|
I have tested this item ✅ successfully on b304e06 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38244. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38244. |
|
Thank you. |
joomla/joomla-cms#36749 + joomla/joomla-cms#38228 + joomla/joomla-cms#38227 - (только для en-GB, у нас исправлено ранее) joomla/joomla-cms#38255 + joomla/joomla-cms#38244 + joomla/joomla-cms#38271 - (только для en-GB, у нас исправлено ранее) joomla/joomla-cms#38287 - (только для en-GB, у нас исправлено ранее) joomla/joomla-cms#38301 - (только для en-GB, у нас исправлено ранее)
|
@chmst found out that this field breaks if you set a default value |
|
So I checked and the Since the default makes no sense here, I will create a PR where the field itself can decide if the |
|
PR created: #38423 |
This reverts commit 32ef564 Signed-off-by: Roland Dalmulder <contact@rolandd.com>
|
This PR has unfortunately been reverted as there are more issues to be resolved. Related PRs with fixes are:
It is best to roll this PR and the other PRs into 1 new PR for 4.3, so we have more time to test and verify the solutions. |
|
only because we both misread each others comments |
|
Best thing would be to offer the plugin in the JED and not bloat the core. |
|
Why? Then we should remove all the plugins that are for core fields. Honestly that makes zero sense. |
|
Because core has already over 200 extensions when you do a blank installation, which I think is more than enough. Instead of, we should try to push the extension directory. |
Add back the update SQL script "4.2.0-2022-07-07.sql" which were added with PR joomla#38244 and released with 4.2.0-rc1 and then later removed before 4.2.0 stable when that PR was reverted, and comment out their content.
Add new update SQL script to correctly revert PR joomla#38244 when updating from a 4.2.0-rc1.
… RC 1 (#38567) * Add back removed files 4.2.0-2022-07-07.sql Add back the update SQL script "4.2.0-2022-07-07.sql" which were added with PR #38244 and released with 4.2.0-rc1 and then later removed before 4.2.0 stable when that PR was reverted, and comment out their content. * Add new files 4.2.1-2022-08-23.sql Add new update SQL script to correctly revert PR #38244 when updating from a 4.2.0-rc1. * Delete obsolete plugin files and folders on update
This is a combination of joomla#38244 and joomla#38426
Summary of Changes
adds a custom field to show a list of all menu items that can be selected and then displayed as a link in the frontend
Testing Instructions
Install a prebuilt package
or
Install this PR, discover the extension and publish the plugin
Create a menuitem custom field. Check that it shows all menuitems from all menus in the select ;ist and then check on the front end that the link is displayed.
Expected result AFTER applying this Pull Request
Documentation Changes Required
New plugin