[4.2] Fixing labels for Smart Search menu item#38228
Merged
roland-d merged 5 commits intojoomla:4.2-devfrom Jul 11, 2022
Merged
[4.2] Fixing labels for Smart Search menu item#38228roland-d merged 5 commits intojoomla:4.2-devfrom
roland-d merged 5 commits intojoomla:4.2-devfrom
Conversation
Contributor
|
I have tested this item 🔴 unsuccessfully on f28c99e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38228. |
Contributor
|
please alpha sort language strings and why add a new string with identical text This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38228. |
Member
Author
|
Because they are used in pretty different situations. |
Quy
reviewed
Jul 8, 2022
Quy
reviewed
Jul 8, 2022
Co-authored-by: Quy <quy@fluxbb.org>
Co-authored-by: Quy <quy@fluxbb.org>
Contributor
|
I have tested this item ✅ successfully on 7225f8d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38228. |
Contributor
|
I have tested this item ✅ successfully on 7225f8d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38228. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38228. |
Contributor
|
Thanks everybody |
heelc29
added a commit
to heelc29/joomla
that referenced
this pull request
Jul 13, 2022
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Jul 19, 2022
joomla/joomla-cms#36749 + joomla/joomla-cms#38228 + joomla/joomla-cms#38227 - (только для en-GB, у нас исправлено ранее) joomla/joomla-cms#38255 + joomla/joomla-cms#38244 + joomla/joomla-cms#38271 - (только для en-GB, у нас исправлено ранее) joomla/joomla-cms#38287 - (только для en-GB, у нас исправлено ранее) joomla/joomla-cms#38301 - (только для en-GB, у нас исправлено ранее)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The language strings used for the 2 request parameter options in the search view of com_finder have translation keys which have a wrong english translation and which are used in 2 different circumstances for different stuff. This adds additional translation keys and "right" translations.