Conversation
Making things clearer :)
Making things clearer
| PLG_SYSTEM_WEBAUTHN_ERR_NOT_DELETED="Could not remove the authenticator" | ||
| PLG_SYSTEM_WEBAUTHN_ERR_USER_REMOVED="The user for this authenticator seems to no longer exist on this site." | ||
| PLG_SYSTEM_WEBAUTHN_FIELD_DESC="Lets you manage passwordless login methods using the W3C Web Authentication standard. You need a supported browser and authenticator (eg Google Chrome or Firefox with a FIDO2 certified security key)." | ||
| PLG_SYSTEM_WEBAUTHN_FIELD_DESC="Lets you manage passwordless login methods using the W3C Web Authentication standard. You need a supported browser and authenticator (eg Google Chrome or Firefox with a FIDO2 certified security key). <br /><br /><strong>Apple:</strong> Touch/Face ID <br /><strong>Windows:</strong> Hello (Fingerprint / Facial Recognition / PIN) <br /><strong>Android:</strong> Biometric screen lock" |
There was a problem hiding this comment.
Please change to just <br> and end the text with a period
There was a problem hiding this comment.
Perhaps also replace Apple as the manufacturer with the name of the operating system "MacOS/iOS/watchOS".
Should Linux be named?
Does Chrome OS now have enough market share and need to be mentioned?
A quick search on Google revealed that Chrome OS now has more market share than macOS.
|
Lets wait for @nikosdion s PR and some more tests. Joomlas language override fields convert < br > to < br /> on save/reload, so I accepted that. Should we also link @ceford s detail-documentation directly from PLG_SYSTEM_WEBAUTHN_FIELD_DESC ? |
That's a bug which hopefully will get fixed. Please make the requested chanage |
Improved
|
There are unnecessary spaces before and after br. Please delete. Furthermore, I see no need for the last sentence and the link here. |
|
I got used to add EOL spaces for anti-glued sentences if somehow line breaks get lost (or just take copy/paste w/o line breaks). Unlikely here, so I will remove them (cannot hurt anyway). For the "read more" link, last sentence - I think it is good and very, very useful to have them in scope, like "read more" in frontend. Its just following the intro/short form. The top right help button is not really in scope and that last sentence with link does not hurt anything/anybody - rather the opposite. Maybe theres another 3rd party opinion on that - updated PR will follow. |
Removed br spaces and adjusted the link href to the language specific doc.
Inserted /Special:MyLanguage/ also into the link anchor. Was unsure about that before.
Co-authored-by: Stefan Wendhausen <stefan.wendhausen@tec-promotion.de>
|
Thx @tecpromotion - to change only the one string makes sense to save the translators crowd from unnecessary work (y) |
finally...
|
I have tested this item ✅ successfully on a4a2140 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37203. |
1 similar comment
|
I have tested this item ✅ successfully on a4a2140 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37203. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37203. |
|
Thx |
joomla/joomla-cms#35323 + joomla/joomla-cms#35693 + joomla/joomla-cms#36279 - (у нас не было термина "рендеринг") joomla/joomla-cms#36714 + joomla/joomla-cms#36865 + joomla/joomla-cms#36875 + joomla/joomla-cms#37014 + joomla/joomla-cms#37033 + joomla/joomla-cms#37043 - (только для других языков) joomla/joomla-cms#37049 - (только для en-GB) joomla/joomla-cms#37092 + joomla/joomla-cms#37104 + joomla/joomla-cms#37119 + joomla/joomla-cms#37129 + joomla/joomla-cms#37133 + joomla/joomla-cms#37196 + joomla/joomla-cms#37203 + joomla/joomla-cms#37224 + joomla/joomla-cms#37238 +
Pull Request for Issue # .
Summary of Changes
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required