[4.1] Private Messages Emails#37133
Merged
HLeithner merged 2 commits intojoomla:4.1-devfrom Mar 11, 2022
Merged
Conversation
PR for joomla#29533 (and more) Since the component was changed to include the actual message in the email it is no longer a notification so I updated the description show in the mail templates component Before this PR the subject of the email that was generated was New Message from <user> at <sitename> The actual subject of the message was included in the body of the email. "New Message from <user>" is not needed. We know who the email is from in the usual way and our inbox will show if it is new or not ;) This also meant that you would have an inbox with multiple messages that all had the exact same title :( With this PR the subject of the email that is generated is [<sitename>] - Subject and the body of the email only contains the body of the message not subject and body. The messages can of course still be managed and updated with the mail templates component. This is just setting a better default.
Contributor
|
If the name of the website (sitename) is long, there is a risk that the subject will get lost in the background. |
Contributor
Author
|
I definitely want the sitename to be first for the exact scenario you suggest. If sitea is more important to me than siteb then I want to be sure that I can see which site it is in the message. But as its configurable now then a user could change it as they see fit. |
tecpromotion
approved these changes
Mar 6, 2022
Contributor
tecpromotion
left a comment
There was a problem hiding this comment.
thanks @brianteeman
Contributor
|
I have tested this item ✅ successfully on 7be569e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37133. |
Quy
reviewed
Mar 6, 2022
Contributor
|
I have tested this item ✅ successfully on 7be569e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37133. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37133. |
Member
|
Thanks |
Contributor
Author
|
thanks |
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Mar 15, 2022
joomla/joomla-cms#35323 + joomla/joomla-cms#35693 + joomla/joomla-cms#36279 - (у нас не было термина "рендеринг") joomla/joomla-cms#36714 + joomla/joomla-cms#36865 + joomla/joomla-cms#36875 + joomla/joomla-cms#37014 + joomla/joomla-cms#37033 + joomla/joomla-cms#37043 - (только для других языков) joomla/joomla-cms#37049 - (только для en-GB) joomla/joomla-cms#37092 + joomla/joomla-cms#37104 + joomla/joomla-cms#37119 + joomla/joomla-cms#37129 + joomla/joomla-cms#37133 + joomla/joomla-cms#37196 + joomla/joomla-cms#37203 + joomla/joomla-cms#37224 + joomla/joomla-cms#37238 +
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for #29533 (and more)
Since the component was changed to include the actual message in the email it is no longer a notification so I updated the description show in the mail templates component
Before this PR the subject of the email that was generated was
New Message from <user> at <sitename>The actual subject of the message was included in the body of the email.
"New Message from " is not needed. We know who the email is from in the usual way and our inbox will show if it is new or not ;)
This also meant that you would have an inbox with multiple messages that all had the exact same title :(
With this PR the subject of the email that is generated is
[<sitename>] - Subjectand the body of the email only contains the body of the message not subject and body.
The messages can of course still be managed and updated with the mail templates component. This is just setting a better default.