[4.1] add rel=\"noopener noreferrer\" for target=\"blank\" links#37014
Merged
bembelimen merged 3 commits intojoomla:4.1-devfrom Feb 22, 2022
Merged
[4.1] add rel=\"noopener noreferrer\" for target=\"blank\" links#37014bembelimen merged 3 commits intojoomla:4.1-devfrom
bembelimen merged 3 commits intojoomla:4.1-devfrom
Conversation
Contributor
|
I have tested this item ✅ successfully on 2c407d7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37014. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 2c407d7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37014. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37014. |
Contributor
|
Thx |
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Mar 15, 2022
joomla/joomla-cms#35323 + joomla/joomla-cms#35693 + joomla/joomla-cms#36279 - (у нас не было термина "рендеринг") joomla/joomla-cms#36714 + joomla/joomla-cms#36865 + joomla/joomla-cms#36875 + joomla/joomla-cms#37014 + joomla/joomla-cms#37033 + joomla/joomla-cms#37043 - (только для других языков) joomla/joomla-cms#37049 - (только для en-GB) joomla/joomla-cms#37092 + joomla/joomla-cms#37104 + joomla/joomla-cms#37119 + joomla/joomla-cms#37129 + joomla/joomla-cms#37133 + joomla/joomla-cms#37196 + joomla/joomla-cms#37203 + joomla/joomla-cms#37224 + joomla/joomla-cms#37238 +
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
during the translation i stumbled across some links with target=_blank without rel="noopener noreferrer".
A global search found only 9 more occurrences.
Testing Instructions
check if the links still work
Actual result BEFORE applying this Pull Request
e.g.
PLG_SYSTEM_JOOA11Y_HEADING_FIRST="The first heading on a page should usually be a Heading 1 or Heading 2. Heading 1 should be the start of the main content section, and is the main heading that describes the overall purpose of the page. Learn more about <a href=\"https://www.w3.org/WAI/tutorials/page-structure/headings/\" target=\"_blank\">Heading Structure.</a>"Expected result AFTER applying this Pull Request
e.g.
PLG_SYSTEM_JOOA11Y_HEADING_FIRST="The first heading on a page should usually be a Heading 1 or Heading 2. Heading 1 should be the start of the main content section, and is the main heading that describes the overall purpose of the page. Learn more about <a href=\"https://www.w3.org/WAI/tutorials/page-structure/headings/\" target=\"_blank\" rel=\"noopener noreferrer\">Heading Structure.</a>"Documentation Changes Required
.