[4] Rename phpunit test folders to align with the apps structure#36483
Merged
wilsonge merged 2 commits intojoomla:4.0-devfrom Dec 30, 2021
PhilETaylor:refactor-tests-folder
Merged
[4] Rename phpunit test folders to align with the apps structure#36483wilsonge merged 2 commits intojoomla:4.0-devfrom PhilETaylor:refactor-tests-folder
wilsonge merged 2 commits intojoomla:4.0-devfrom
PhilETaylor:refactor-tests-folder
Conversation
This comment was marked as abuse.
This comment was marked as abuse.
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#36482 introduces our first Unit test for Joomla 4 extensions methods
Previously the only tests are for the libraries/src/* classes in the /test/Unit/Libraries/CMS folder which makes no sense
The Unit testing folder structure should reflect the path structure of the code its testing (Best Practice)
This PR renames the folders - the tests still run perfectly fine.
This will eventually conflict with #36482 potentially depending on which is merged first, but I'll fix that myself when I see that happen.