Revert "[4] Rename phpunit test folders to align with the apps structure"#36498
Merged
Revert "[4] Rename phpunit test folders to align with the apps structure"#36498
Conversation
This comment was marked as abuse.
This comment was marked as abuse.
Contributor
Author
|
For sure - otherwise I wouldn't have merged it :) Just definitely screws with the composer autoload here I think https://github.com/joomla/joomla-cms/blob/4.0-dev/composer.json#L30-L34 - if we go down this route I think we have to re-amend all the namespaces (or change the autoloading method) |
This comment was marked as abuse.
This comment was marked as abuse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #36483
@PhilETaylor this broke the composer autoloading (apparently drone didn't fail because it still uses composer v1 🤦 ). But if you look at the original PR "composer" section in Drone you can see the warnings for composer v2