[4][com_finder] - php 8.1 serializable-deprecated with unit test#36482
Closed
PhilETaylor wants to merge 14 commits intojoomla:4.1-devfrom
PhilETaylor:php81findercornflakes
Closed
[4][com_finder] - php 8.1 serializable-deprecated with unit test#36482PhilETaylor wants to merge 14 commits intojoomla:4.1-devfrom PhilETaylor:php81findercornflakes
PhilETaylor wants to merge 14 commits intojoomla:4.1-devfrom
PhilETaylor:php81findercornflakes
Conversation
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
alikon
suggested changes
Dec 30, 2021
Contributor
|
I have tested this item ✅ successfully on 50e03bd This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36482. |
Member
|
Can you make an update to the branch to retrigger drone (emojis in the description... I think I have to check drone why this happens maybe mb4 on mysql) |
This comment was marked as abuse.
This comment was marked as abuse.
added 2 commits
December 30, 2021 13:41
This comment was marked as abuse.
This comment was marked as abuse.
Member
That's ok, all php8+ system tests are allowed to fail and 8.1 unit tests too, also postgres system tests |
wilsonge
reviewed
Dec 30, 2021
wilsonge
approved these changes
Dec 30, 2021
wilsonge
reviewed
Jan 8, 2022
tests/Unit/CMS/administrator/components/com_finder/src/Indexer/ResultTest.php
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replacement of #36473 with Unit tests that run before and after with success (although correctly, before this PR the unit test has the deprecation warning.
@richard67 @alikon
Summary of Changes
added magic method
Testing Instructions
php 8.1
on frontend do a search
check the log
Actual result BEFORE applying this Pull Request
PHP Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary)
Expected result AFTER applying this Pull Request
no more deprecation
Note
This is our FIRST EVER Unit test for a method in Joomla 4 Extensions it seems... woot woot (also see: #36483)