Skip to content

[4.0] responsive buttons#33899

Merged
richard67 merged 1 commit intojoomla:4.0-devfrom
brianteeman:buttons
May 18, 2021
Merged

[4.0] responsive buttons#33899
richard67 merged 1 commit intojoomla:4.0-devfrom
brianteeman:buttons

Conversation

@brianteeman
Copy link
Copy Markdown
Contributor

@brianteeman brianteeman commented May 15, 2021

Adds margin-bottom to all buttons only when media-breakpoint-down(sm)

Fix it in one place instead of having to fix every existing button and remembering to fix every future button

image

image

image

@brianteeman
[4.0] responsive buttons
f8bb6bc 
Adds margin-bottom to all buttons only when media-breakpoint-down(sm)
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels May 15, 2021
@brianteeman brianteeman mentioned this pull request May 15, 2021
Closed
@richard67 richard67 mentioned this pull request May 15, 2021
Closed
@richard67
Copy link
Copy Markdown
Member

richard67 commented May 15, 2021

@brianteeman Could you add a "Pull Request for Issue #33717 ." to the description? Thanks in advance.

@brianteeman
Copy link
Copy Markdown
Contributor Author

brianteeman commented May 15, 2021

@richard67 its for more than just that PR - its a general issue

@richard67
Copy link
Copy Markdown
Member

richard67 commented May 15, 2021

@brianteeman Yes, but it would help us to reference the issues. To me it looks as if this PR here also replaces #33899 , is that right?

@brianteeman
Copy link
Copy Markdown
Contributor Author

brianteeman commented May 15, 2021

Github already did the reference

image

To me it looks as if this PR here also replaces #33899 , is that right?

image

@richard67
Copy link
Copy Markdown
Member

richard67 commented May 15, 2021

@brianteeman Ahh I pasted the wrong number. I meant #33893 . We have #33893 and #33895 open, and both would be obsolete with this one here, which is the better way, I agree with you.

@brianteeman brianteeman mentioned this pull request May 15, 2021
Merged
brianteeman added a commit to brianteeman/joomla-cms that referenced this pull request May 15, 2021
@brianteeman
[4.0] Revert changes in joomla#33717
5992e1b 
This is the wrong approach and should not have been merged. You dont solve a responsive issue by adding a global class. please see joomla#33899

By using the correct code you do not need to keep adding classes to buttons. Using only joomla#33899 this is fixed correctly
@brianteeman brianteeman mentioned this pull request May 15, 2021
Merged
@Quy Quy mentioned this pull request May 15, 2021
Closed
@brianteeman
Copy link
Copy Markdown
Contributor Author

brianteeman commented May 15, 2021

@deveshprasad that is unrelated as that field is in the frontend and this PR is for the admin

@Quy
Copy link
Copy Markdown
Contributor

Quy commented May 15, 2021

I have tested this item ✅ successfully on f8bb6bc

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33899.

1 similar comment
@ghost
Copy link
Copy Markdown

ghost commented May 16, 2021

I have tested this item ✅ successfully on f8bb6bc

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33899.

@Quy
Copy link
Copy Markdown
Contributor

Quy commented May 16, 2021

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33899.

@Quy Quy removed the NPM Resource Changed This Pull Request can't be tested by Patchtester label May 16, 2021
@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 16, 2021
@Quy Quy added this to the Joomla 4.0 milestone May 16, 2021
chmst pushed a commit that referenced this pull request May 18, 2021
@brianteeman
[4.0] Revert changes in #33717 (#33902)
cd33f73 
This is the wrong approach and should not have been merged. You dont solve a responsive issue by adding a global class. please see #33899

By using the correct code you do not need to keep adding classes to buttons. Using only #33899 this is fixed correctly
@richard67 richard67 merged commit 2deeda0 into joomla:4.0-dev May 18, 2021
@joomla-cms-bot joomla-cms-bot added the NPM Resource Changed This Pull Request can't be tested by Patchtester label May 18, 2021
@richard67
Copy link
Copy Markdown
Member

richard67 commented May 18, 2021

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 18, 2021
@brianteeman brianteeman deleted the buttons branch May 18, 2021 18:46
@brianteeman
Copy link
Copy Markdown
Contributor Author

brianteeman commented May 18, 2021

Thank you

@Quy Quy mentioned this pull request May 18, 2021
Closed
brianteeman added a commit to brianteeman/joomla-cms that referenced this pull request May 22, 2021
@brianteeman
[4.0] margin-bottom input groups
2335af4 
A previous pr of mine joomla#33899 was too aggressive. This resolves that. See joomla#34106 for test instructions

Dont forget this is a css change so npm run build:css
@brianteeman brianteeman mentioned this pull request May 22, 2021
Merged
Quy pushed a commit that referenced this pull request May 23, 2021
@brianteeman
[4.0] margin-bottom input groups (#34112)
3c5850e 
* [4.0] margin-bottom input groups

A previous pr of mine #33899 was too aggressive. This resolves that. See #34106 for test instructions

Dont forget this is a css change so npm run build:css

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Milestone

Joomla 4.0

Development

Successfully merging this pull request may close these issues.

4 participants

@brianteeman @richard67 @Quy @joomla-cms-bot