Responsive Issues on different screen sizes #33717#33893
Merged
HLeithner merged 1 commit intojoomla:4.0-devfrom May 15, 2021
deveshprasad:temp
Merged
Responsive Issues on different screen sizes #33717#33893HLeithner merged 1 commit intojoomla:4.0-devfrom deveshprasad:temp
HLeithner merged 1 commit intojoomla:4.0-devfrom
deveshprasad:temp
Conversation
|
I have tested this item ✅ successfully on 9edac5a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33893. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 9edac5a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33893. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33893. |
Member
|
Thanks |
Contributor
|
This is the wrong approach and should not have been merged. You dont solve a responsive issue by adding a global class. please see #33899 |
Contributor
|
By using the correct code you do not need to keep adding classes to buttons. Using only #33899 this is fixed correctly
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #33717.
Summary of Changes
Added Y-axis margin to both the buttons as individual will affect its alignment vertically.
(I have asked on my previous pull request #33824 regarding the method to use as the button.scss file is creating error so followed bootstrap margin)
Testing Instructions
Go to the Post Installation Messages page.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
No