[4.0] Check out improvements related to nullable columns#30747
Merged
HLeithner merged 3 commits intojoomla:4.0-devfrom Sep 24, 2020
SharkyKZ:j4/fix/null-check-out
Merged
[4.0] Check out improvements related to nullable columns#30747HLeithner merged 3 commits intojoomla:4.0-devfrom SharkyKZ:j4/fix/null-check-out
HLeithner merged 3 commits intojoomla:4.0-devfrom
SharkyKZ:j4/fix/null-check-out
Conversation
richard67
reviewed
Sep 23, 2020
administrator/components/com_checkin/src/Model/CheckinModel.php
Outdated
Show resolved
Hide resolved
Member
|
@mahagr Could you test this PR and mark the test result in the issue tracker? Thanks in advance. |
Contributor
|
I have tested this item ✅ successfully on 97d2867 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30747. |
Contributor
|
I have tested this item ✅ successfully on 97d2867 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30747. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30747. |
Member
|
Thanks |
Member
|
RTC |
dgrammatiko
added a commit
to dgrammatiko/joomla-cms
that referenced
this pull request
Sep 26, 2020
* Joomla/4.0-dev: (844 commits) [4.0] Template layout select (joomla#30772) [4.0][CLI] com_finder use console command (joomla#30768) [4.0] Modifying com_actionlogs string (joomla#30758) [4.0] Fancy selectbox fix (joomla#30739) [4.0] Add missing Table Caption (joomla#30763) [4.0] Wrap all buttons in btn-group to improve styling (joomla#30761) [4.0] Cassiopeia missing string (joomla#30765) Improve batch text (joomla#28447) Fix icons not displaying (joomla#30749) Remove the chrome "cardGrey". The same effect can be achieved by using the module class "card-grey" with the "card" chrome (joomla#30734) Remove obsolete html code (joomla#30737) [4.0] Check out improvements related to nullable columns (joomla#30747) Removing card.scss overrides as we don't use those classes Use renderField() method to render fields (joomla#30738) [4.0] spelling (joomla#30742) [4.0] Remove use of ReflectionParameter::getClass() (joomla#30581) [4.0] Fix saving images (joomla#30730) [4.0] Cleanup cassiopeia chromes and rename "default" to "card" (joomla#30729) Fix hiddenLabel and add hiddenLegend form attribute (joomla#29710) [4.0] Fix Debug plugin to display query parameters (joomla#30717) ...
dgrammatiko
added a commit
to dgrammatiko/joomla-cms
that referenced
this pull request
Sep 29, 2020
…ger_events_consistency * '4.0-dev' of github.com:joomla/joomla-cms: (84 commits) [4.0] Error in legacy plugins when method contains $event argument (joomla#30575) [4.0] Cassiopea table css (joomla#30740) [4.0] Blog view links (joomla#30788) Change grid minmax definition for newsflash module (joomla#30781) [4.0] Pluginless lazyloading for the core (joomla#30748) Update package-lock.json (joomla#30713) [4.0] mod_article_news readmore (joomla#30780) Improve code, remove separator (joomla#30785) [4.0] Template layout select (joomla#30772) [4.0][CLI] com_finder use console command (joomla#30768) [4.0] Modifying com_actionlogs string (joomla#30758) [4.0] Fancy selectbox fix (joomla#30739) [4.0] Add missing Table Caption (joomla#30763) [4.0] Wrap all buttons in btn-group to improve styling (joomla#30761) [4.0] Cassiopeia missing string (joomla#30765) Improve batch text (joomla#28447) Fix icons not displaying (joomla#30749) Remove the chrome "cardGrey". The same effect can be achieved by using the module class "card-grey" with the "card" chrome (joomla#30734) Remove obsolete html code (joomla#30737) [4.0] Check out improvements related to nullable columns (joomla#30747) ... � Conflicts: � administrator/components/com_media/resources/scripts/app/Api.js � administrator/components/com_media/resources/scripts/components/toolbar/toolbar.vue � package-lock.json
sakiss
pushed a commit
to sakiss/joomla-cms
that referenced
this pull request
Oct 16, 2020
* Show 0 values as checked out in nullable columns * Check in 0 values in nullable columns * Change comparison
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30731.
Summary of Changes
Adds nullable checks for proper handling of 0 value in
com_checkin.Testing Instructions
Set
checked_outfield value to0in one of core tables, e.g by running this query:Go to
com_checkin.It would also be good to test that check in still works with 3rd party components that don't use null values.
Actual result BEFORE applying this Pull Request
#__menutable not listed as having checked out items.Expected result AFTER applying this Pull Request
#__menutable listed as having checked out items and items can be checked in properly.Documentation Changes Required
No.