[4.0] Error in legacy plugins when method contains $event argument#30575
[4.0] Error in legacy plugins when method contains $event argument#30575laoneo merged 5 commits intojoomla:4.0-devfrom SharkyKZ:j4/bug/plugin-event
Conversation
|
Installed dummy plugin. Joomla 4.0.0-beta4 Couldn't return to Dashboard & now site is broken. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30575. |
|
That's expected behavior before patch. |
|
I have tested this item ✅ successfully on 7e7b73c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30575. |
Of course, the message before patch was expected, but not, that my site becomes complety broken. What I did: Therefore I deleted space/database and installed fully nightly 4.0.0-beta5 plus Patchtester etc. |
|
Hmmm: After successful Patch (see above) I reverted it and got the failure again. Backend broken now. For other testers: Please before reverting Patch: de-active Plugin .... This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30575. |
|
I hope you're not testing on live site 😅 |
It's a live site (space), but for testing purposes only of course :-) |
|
I have tested this item ✅ successfully on 7e7b73c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30575. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30575. |
|
Conflicts here... |
|
Conflicts fixed. |
|
Last commit changes condition order for optimization. No change in functionality. |
|
Thanks! |
…ger_events_consistency * '4.0-dev' of github.com:joomla/joomla-cms: (84 commits) [4.0] Error in legacy plugins when method contains $event argument (joomla#30575) [4.0] Cassiopea table css (joomla#30740) [4.0] Blog view links (joomla#30788) Change grid minmax definition for newsflash module (joomla#30781) [4.0] Pluginless lazyloading for the core (joomla#30748) Update package-lock.json (joomla#30713) [4.0] mod_article_news readmore (joomla#30780) Improve code, remove separator (joomla#30785) [4.0] Template layout select (joomla#30772) [4.0][CLI] com_finder use console command (joomla#30768) [4.0] Modifying com_actionlogs string (joomla#30758) [4.0] Fancy selectbox fix (joomla#30739) [4.0] Add missing Table Caption (joomla#30763) [4.0] Wrap all buttons in btn-group to improve styling (joomla#30761) [4.0] Cassiopeia missing string (joomla#30765) Improve batch text (joomla#28447) Fix icons not displaying (joomla#30749) Remove the chrome "cardGrey". The same effect can be achieved by using the module class "card-grey" with the "card" chrome (joomla#30734) Remove obsolete html code (joomla#30737) [4.0] Check out improvements related to nullable columns (joomla#30747) ... � Conflicts: � administrator/components/com_media/resources/scripts/app/Api.js � administrator/components/com_media/resources/scripts/components/toolbar/toolbar.vue � package-lock.json
…oomla#30575) * Error in legacy plugins when method contains $event argument * Unnecessary parentheses * Correct comment * Optimize
Summary of Changes
Fixes legacy plugins being registered as modern plugins when method takes
$eventargument.Testing Instructions
install and enable this plugin: plg_system_dummy.zip.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
No errors.
Documentation Changes Required
No.