[4.0] Fix saving images#30730
Merged
infograf768 merged 3 commits intojoomla:4.0-devfrom Sep 23, 2020
SharkyKZ:j4/fix/media-image-save
Merged
[4.0] Fix saving images#30730infograf768 merged 3 commits intojoomla:4.0-devfrom SharkyKZ:j4/fix/media-image-save
infograf768 merged 3 commits intojoomla:4.0-devfrom
SharkyKZ:j4/fix/media-image-save
Conversation
Member
|
@SharkyKZ There are javascript lint errors: https://ci.joomla.org/joomla/joomla-cms/35601/1/23. |
Member
|
I always get a correct success message when modifying image title and using Save. |
Member
|
I have tested this item ✅ successfully on b096991 Findings by @infograf768 could be fixed with another, future PR. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30730. |
Member
|
I have tested this item ✅ successfully on b096991 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30730. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30730. |
Member
|
Tks. |
dgrammatiko
added a commit
to dgrammatiko/joomla-cms
that referenced
this pull request
Sep 26, 2020
* Joomla/4.0-dev: (844 commits) [4.0] Template layout select (joomla#30772) [4.0][CLI] com_finder use console command (joomla#30768) [4.0] Modifying com_actionlogs string (joomla#30758) [4.0] Fancy selectbox fix (joomla#30739) [4.0] Add missing Table Caption (joomla#30763) [4.0] Wrap all buttons in btn-group to improve styling (joomla#30761) [4.0] Cassiopeia missing string (joomla#30765) Improve batch text (joomla#28447) Fix icons not displaying (joomla#30749) Remove the chrome "cardGrey". The same effect can be achieved by using the module class "card-grey" with the "card" chrome (joomla#30734) Remove obsolete html code (joomla#30737) [4.0] Check out improvements related to nullable columns (joomla#30747) Removing card.scss overrides as we don't use those classes Use renderField() method to render fields (joomla#30738) [4.0] spelling (joomla#30742) [4.0] Remove use of ReflectionParameter::getClass() (joomla#30581) [4.0] Fix saving images (joomla#30730) [4.0] Cleanup cassiopeia chromes and rename "default" to "card" (joomla#30729) Fix hiddenLabel and add hiddenLegend form attribute (joomla#29710) [4.0] Fix Debug plugin to display query parameters (joomla#30717) ...
sakiss
pushed a commit
to sakiss/joomla-cms
that referenced
this pull request
Oct 16, 2020
* Fix saving images * Typo * CS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30664 and #28842.
Summary of Changes
Fixes saving images after editing in media manager.
Testing Instructions
node build.js --compile-jsrequired.Edit an article.
In editor click
CMS Content->Image.Edit an image in the modal.
Click
Save & Close.Actual result BEFORE applying this Pull Request
Modified image is not saved and modules appear in the modal after redirect.
Expected result AFTER applying this Pull Request
Modified images is saved and your are redireceted back to media list without modules showing.
Documentation Changes Required
No.