Improvement: Adding the forced language in the modal title for Articles#11749
Merged
rdeutz merged 1 commit intojoomla:stagingfrom Aug 24, 2016
Merged
Conversation
Contributor
|
I have tested this item ✅ successfully on 74af0dd This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11749. |
Contributor
|
I have tested this item ✅ successfully on 74af0dd This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11749. |
Contributor
|
RTC. Thanks. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11749. |
| { | ||
| $linkArticles .= '&forcedLanguage=' . $this->element['language']; | ||
| $linkArticle .= '&forcedLanguage=' . $this->element['language']; | ||
| $modalTitle = JText::_('COM_CONTENT_CHANGE_ARTICLE') . ' — ' . $this->element['label']; |
Contributor
There was a problem hiding this comment.
Does this not really need to be a sprintf?
Member
Author
There was a problem hiding this comment.
it is not necessary and works in rtl. same pr as the others.
Member
Author
There was a problem hiding this comment.
- no lang string change...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #11718 and #11717
Multilingual site
After patch when selecting an article in the Associations tab we will get the following modal
@jreys @brianteeman @andrepereiradasilva @jeckodevelopment