Skip to content

Improvement: Adding the forced language in the modal title for Contacts and Newsfeeds#11718

Merged
rdeutz merged 2 commits intojoomla:stagingfrom
infograf768:forcedlanguage_modal
Aug 24, 2016
Merged

Improvement: Adding the forced language in the modal title for Contacts and Newsfeeds#11718
rdeutz merged 2 commits intojoomla:stagingfrom
infograf768:forcedlanguage_modal

Conversation

@infograf768
Copy link
Copy Markdown
Member

@infograf768 infograf768 commented Aug 22, 2016 •
edited
Loading

To test on a multingual site.
When using associations and selecting a News Feed or a Contact, the language title is appended to the Modal title.

After patch:
screen shot 2016-08-22 at 08 46 01

screen shot 2016-08-22 at 09 04 20

This PR also normalizes some language string.
See also for categories #11717

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-staging labels Aug 22, 2016
@jreys
Copy link
Copy Markdown
Contributor

jreys commented Aug 22, 2016

I have tested this item ✅ successfully on 3b7a5e2

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11718.

@jreys
Copy link
Copy Markdown
Contributor

jreys commented Aug 22, 2016

Aside from the successful test, it would look a lot better like this, since the language is always the same, there is a useless column there, in this mockup I've removed it and added the language with a flag bellow, see what you think, if it's not worth the effort nvm :)

image

@infograf768
Copy link
Copy Markdown
Member Author

infograf768 commented Aug 22, 2016

Imho, the column is still useful. A confirmation of the language used.
Also, when we are not in forcedlanguage (associations), we do need it.
Example:
screen shot 2016-08-22 at 10 23 07

andrepereiradasilva
andrepereiradasilva reviewed Aug 22, 2016
View reviewed changes
administrator/components/com_newsfeeds/models/fields/modal/newsfeed.php Outdated
{
$linkNewsfeeds .= '&forcedLanguage=' . $this->element['language'];
$linkNewsfeed .= '&forcedLanguage=' . $this->element['language'];
$modalTitle = JText::_('COM_NEWSFEEDS_CHANGE_FEED') . ' (' . $this->element['label'] . ')';
Copy link
Copy Markdown
Contributor

@andrepereiradasilva andrepereiradasilva Aug 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will we not have issues on RTL languages with this?

@andrepereiradasilva
Copy link
Copy Markdown
Contributor

andrepereiradasilva commented Aug 22, 2016

seems all fine, except the possible RTL issue.

@infograf768
Copy link
Copy Markdown
Member Author

infograf768 commented Aug 22, 2016

Replied concerning the rtl in the other PR
Can you mark the test OK?

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Aug 22, 2016

When you create a multilingual joomla website from the installer the content languages are all created in the form
French (FR)
English (United States)
Danish (da-DK)
English (UK)

Which means that you now have nested brackets like
Select or Change Contact (English (UK))
To avoid that I would just remove the bracket and have a dash between the string and the language

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11718.

@andrepereiradasilva
Copy link
Copy Markdown
Contributor

andrepereiradasilva commented Aug 22, 2016

I have tested this item ✅ successfully on 3b7a5e2

works as described

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11718.

@jeckodevelopment
Copy link
Copy Markdown
Member

jeckodevelopment commented Aug 22, 2016 •
edited
Loading

@infograf768 can you remove brackets? After that we can change this to RTC.

@infograf768
Copy link
Copy Markdown
Member Author

infograf768 commented Aug 22, 2016

Parenthesis replaced by mdash. Here in RTL
screen shot 2016-08-22 at 15 30 45

jeckodevelopment
jeckodevelopment reviewed Aug 22, 2016
View reviewed changes
administrator/components/com_contact/models/fields/modal/contact.php
$linkContacts .= '&forcedLanguage=' . $this->element['language'];
$linkContact .= '&forcedLanguage=' . $this->element['language'];
$modalTitle = JText::_('COM_CONTACT_CHANGE_CONTACT') . ' (' . $this->element['label'] . ')';
$modalTitle = JText::_('COM_CONTACT_CHANGE_CONTACT') . ' — ' . $this->element['label'];
Copy link
Copy Markdown
Member

@jeckodevelopment jeckodevelopment Aug 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why — instead of – ?

Copy link
Copy Markdown
Member Author

@infograf768 infograf768 Aug 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not? It really separates well 2 things which are different. Also we may have already a ndash for the lang tag. Do you have anything personal against mdash ? 😸

@infograf768 infograf768 mentioned this pull request Aug 22, 2016
Merged
@infograf768
Copy link
Copy Markdown
Member Author

infograf768 commented Aug 22, 2016

rtc

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11718.

@andrepereiradasilva
Copy link
Copy Markdown
Contributor

andrepereiradasilva commented Aug 22, 2016

I have tested this item ✅ successfully on 33d713a

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11718.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 22, 2016
@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Aug 22, 2016

Thank you @infograf768

On 22 August 2016 at 14:45, andrepereiradasilva notifications@github.com
wrote:

I have tested this item ✅ successfully on 33d713a

33d713a

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/11718
https://issues.joomla.org/tracker/joomla-cms/11718.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11718 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8X1QKqoBxp40wu_3E9hvo6Wnu54Kks5qiafegaJpZM4Jpklu
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@infograf768
Copy link
Copy Markdown
Member Author

infograf768 commented Aug 22, 2016

Folks, need testing these 3.7 PRs
#11694
#11721

Thanks

@jeckodevelopment jeckodevelopment added this to the Joomla 3.6.3 milestone Aug 22, 2016
This was referenced Aug 23, 2016
Merged
Closed
@infograf768
Copy link
Copy Markdown
Member Author

infograf768 commented Aug 23, 2016

#11751 separated from #11717

@rdeutz rdeutz merged commit 07147e2 into joomla:staging Aug 24, 2016
@infograf768 infograf768 deleted the forcedlanguage_modal branch August 24, 2016 07:31
@brianteeman brianteeman removed the RTC This Pull Request is Ready To Commit label Aug 24, 2016
roland-d pushed a commit to roland-d/joomla-cms that referenced this pull request Sep 11, 2016
@infograf768 @roland-d
Improvement: Adding the forced language in the modal title for Contac…
f84e6a3 
…ts and Newsfeeds (joomla#11718)

* Improvement: Adding the forced language in the modal title for Contacts
and Newsfeeds

* replacing parenthesis by mdash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Language Change This is for Translators

Projects

None yet

Milestone

Joomla 3.6.3

Development

Successfully merging this pull request may close these issues.

7 participants

@infograf768 @jreys @andrepereiradasilva @brianteeman @jeckodevelopment @rdeutz @joomla-cms-bot