Skip to content

Improvement: Using modal_category field in various core locations#11717

Closed
infograf768 wants to merge 3 commits intojoomla:stagingfrom
infograf768:category_modals
Closed

Improvement: Using modal_category field in various core locations#11717
infograf768 wants to merge 3 commits intojoomla:stagingfrom
infograf768:category_modals

Conversation

@infograf768
Copy link
Copy Markdown
Member

@infograf768 infograf768 commented Aug 22, 2016 •
edited
Loading

This PR lets use the existing modal_category field when possible in core, which is quite handy when one has many categories to deal with:

Menu items:
List Contacts in a Category
Content Category blog
Content Category list
List Newsfeeds in a category

Also:
User Notes
mod_articles categories

Example:
screen shot 2016-08-22 at 08 09 11

It also adds in multilingual associations the forcedlanguage in the title of the Select or Change Category modal.
Example, from the already existing:
screen shot 2016-08-22 at 08 12 17

we get when using the Select button:
screen shot 2016-08-22 at 08 16 41

This can go in 3.6.3 as it is not a new feature (contrary to #11694 which depends on the new modal_menu fields already merged in 3.7.0).

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-staging labels Aug 22, 2016
@infograf768 infograf768 mentioned this pull request Aug 22, 2016
Merged
@jreys
Copy link
Copy Markdown
Contributor

jreys commented Aug 22, 2016

I have tested this item ✅ successfully on 1183afc

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11717.

andrepereiradasilva
andrepereiradasilva reviewed Aug 22, 2016
View reviewed changes
administrator/components/com_categories/models/fields/modal/category.php Outdated
{
$linkCategories .= '&forcedLanguage=' . $this->element['language'];
$linkCategory .= '&forcedLanguage=' . $this->element['language'];
$modalTitle = JText::_('COM_CATEGORIES_CHANGE_CATEGORY') . ' (' . $this->element['label'] . ')';
Copy link
Copy Markdown
Contributor

@andrepereiradasilva andrepereiradasilva Aug 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we will have issues in RTL languages here?

@andrepereiradasilva
Copy link
Copy Markdown
Contributor

andrepereiradasilva commented Aug 22, 2016 •
edited
Loading

besides the comment above all seems to work fine

@infograf768
Copy link
Copy Markdown
Member Author

infograf768 commented Aug 22, 2016

RTL looks fine here:
screen shot 2016-08-22 at 11 49 00

Can you mark the test OK?

@andrepereiradasilva
Copy link
Copy Markdown
Contributor

andrepereiradasilva commented Aug 22, 2016

I have tested this item ✅ successfully on 1183afc

works as described

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11717.

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Aug 22, 2016

Same comment as in the other PR regarding the use of the brackets

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11717.

@jeckodevelopment
Copy link
Copy Markdown
Member

jeckodevelopment commented Aug 22, 2016

@infograf768 same here. Remove brackets and it goes to RTC

@infograf768
Copy link
Copy Markdown
Member Author

infograf768 commented Aug 22, 2016

Parenthesis replaced by mdash

screen shot 2016-08-22 at 15 34 42

@infograf768 infograf768 mentioned this pull request Aug 22, 2016
Merged
@andrepereiradasilva
Copy link
Copy Markdown
Contributor

andrepereiradasilva commented Aug 22, 2016

I have tested this item ✅ successfully on 80741f5

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11717.

@infograf768
Copy link
Copy Markdown
Member Author

infograf768 commented Aug 22, 2016

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11717.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 22, 2016
@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Aug 22, 2016

Thank you @infograf768

On 22 August 2016 at 14:44, infograf768 notifications@github.com wrote:

RTC

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/11717
https://issues.joomla.org/tracker/joomla-cms/11717.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11717 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8b8xZFlfgsy4ix3ob-uaJlOPnmCBks5qiae4gaJpZM4JpizU
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@jeckodevelopment jeckodevelopment added this to the Joomla 3.7.0 milestone Aug 22, 2016
@infograf768 infograf768 mentioned this pull request Aug 23, 2016
Merged
@infograf768
Copy link
Copy Markdown
Member Author

infograf768 commented Aug 23, 2016 •
edited
Loading

Why milestone set to 3.7.0? It is NOT a new feature.
This is only an improvement. No additional code.
Please tag to 3.6.3 as done for #11718
and for sure #11749

@rdeutz
Copy link
Copy Markdown
Contributor

rdeutz commented Aug 23, 2016

I agree with the 3.7.0 milestone setting, this here is changing the UI/UX the other PRs are only changing text.

@infograf768
Copy link
Copy Markdown
Member Author

infograf768 commented Aug 23, 2016

In this case, I am ready to modify this PR and only change the modal title without touching at the xmls for now.

@rdeutz
Copy link
Copy Markdown
Contributor

rdeutz commented Aug 23, 2016

@infograf768 sounds good

@infograf768
Copy link
Copy Markdown
Member Author

infograf768 commented Aug 23, 2016

Took off the changes in the modal and will make a new PR with these only in order to get the modal title change in 3.6.3.
This can remain as is now for 3.7.0

@infograf768 infograf768 mentioned this pull request Aug 23, 2016
Merged
@infograf768
Copy link
Copy Markdown
Member Author

infograf768 commented Aug 23, 2016

Please confirm PR #11751

wilsonge added a commit that referenced this pull request Aug 28, 2016
@wilsonge
Merge branch 'modal_category_field' into 3.7.x. Fixes #11717
ef98d6b
@wilsonge
Copy link
Copy Markdown
Contributor

wilsonge commented Aug 28, 2016 •
edited
Loading

Merged with ef98d6b - thanks JM!

@wilsonge wilsonge closed this Aug 28, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Language Change This is for Translators

Projects

None yet

Milestone

Joomla 3.7.0

Development

Successfully merging this pull request may close these issues.

8 participants

@infograf768 @jreys @andrepereiradasilva @brianteeman @jeckodevelopment @rdeutz @wilsonge @joomla-cms-bot