Skip to content

MTN update loky to 2.4.2 and rm set_loky_pickler from public API#804

Merged
tomMoral merged 3 commits intojoblib:masterfrom
tomMoral:CLN_hide_set_loky_pickler
Nov 6, 2018
Merged

MTN update loky to 2.4.2 and rm set_loky_pickler from public API#804
tomMoral merged 3 commits intojoblib:masterfrom
tomMoral:CLN_hide_set_loky_pickler

Conversation

@tomMoral
Copy link
Copy Markdown
Contributor

@tomMoral tomMoral commented Nov 6, 2018

No description provided.

@ogrisel
Copy link
Copy Markdown
Contributor

ogrisel commented Nov 6, 2018

We again got the IOError: [Errno 13] Permission denied failure on appveyor. I am wondering of the new code has not introduce a higher likelihood to trigger that random failure.

@ogrisel
Copy link
Copy Markdown
Contributor

ogrisel commented Nov 6, 2018

There are also PEP8 issues to fix on travis.

Copy link
Copy Markdown
Contributor

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the PEP8 issue, LGTM.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 6, 2018

Codecov Report

Merging #804 into master will increase coverage by 0.69%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #804      +/-   ##
==========================================
+ Coverage   94.56%   95.25%   +0.69%     
==========================================
  Files          44       44              
  Lines        6308     6307       -1     
==========================================
+ Hits         5965     6008      +43     
+ Misses        343      299      -44
Impacted Files Coverage Δ
joblib/__init__.py 100% <ø> (ø) ⬆️
joblib/test/test_memory.py 98.11% <0%> (+0.15%) ⬆️
joblib/test/test_memmapping.py 99.41% <0%> (+0.29%) ⬆️
joblib/test/test_parallel.py 96.71% <0%> (+0.57%) ⬆️
joblib/func_inspect.py 95.45% <0%> (+1.13%) ⬆️
joblib/_parallel_backends.py 94.8% <0%> (+1.2%) ⬆️
joblib/logger.py 86.84% <0%> (+1.31%) ⬆️
joblib/disk.py 81.66% <0%> (+1.66%) ⬆️
joblib/test/common.py 88.13% <0%> (+1.69%) ⬆️
joblib/pool.py 91.37% <0%> (+3.44%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2c510a...f8ace87. Read the comment docs.

@tomMoral tomMoral merged commit cb30324 into joblib:master Nov 6, 2018
@tomMoral tomMoral deleted the CLN_hide_set_loky_pickler branch November 6, 2018 15:37
yarikoptic added a commit to yarikoptic/joblib that referenced this pull request Apr 12, 2019
* tag '0.13.0':
  Release 0.13.0
  Use https (joblib#805)
  MTN bump loky to 2.4.2 (joblib#804)
  DOC: provide some useful variables for Makefile (joblib#794)
  DOC serialization and processes (joblib#803)
  ENH update loky 2.4.0 (joblib#802)
  FIX backward compatibility for nested backend (joblib#789)
  enable python 3.7 (joblib#795)
  memory: add test for call_and_shelve performance (joblib#791)
  FIX nested backend not changed by SequentialBackend (joblib#792)
  cloudpickle 0.6.0 (joblib#788)
  FIX nested backend setting n_jobs=-1 (joblib#785)
  Raises a more explicit exception when a corrupted MemorizedResult is loaded (joblib#768)
  Back to dev mode
yarikoptic added a commit to yarikoptic/joblib that referenced this pull request Apr 12, 2019
* releases:
  Release 0.13.0
  Use https (joblib#805)
  MTN bump loky to 2.4.2 (joblib#804)
  DOC: provide some useful variables for Makefile (joblib#794)
  DOC serialization and processes (joblib#803)
  ENH update loky 2.4.0 (joblib#802)
  FIX backward compatibility for nested backend (joblib#789)
  enable python 3.7 (joblib#795)
  memory: add test for call_and_shelve performance (joblib#791)
  FIX nested backend not changed by SequentialBackend (joblib#792)
  cloudpickle 0.6.0 (joblib#788)
  FIX nested backend setting n_jobs=-1 (joblib#785)
  Raises a more explicit exception when a corrupted MemorizedResult is loaded (joblib#768)
  Back to dev mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants