Merged
Conversation
Contributor
Author
|
This caused the following failure under Python 3.4: _____________________ test_nested_exception_dispatch[loky] _____________________
joblib.externals.loky.process_executor._RemoteTraceback:
"""
Traceback (most recent call last):
File "/home/travis/build/joblib/joblib/joblib/externals/loky/process_executor.py", line 420, in _process_worker
r = call_item.fn(*call_item.args, **call_item.kwargs)
File "/home/travis/build/joblib/joblib/joblib/_parallel_backends.py", line 563, in __call__
return self.func(*args, **kwargs)
File "/home/travis/build/joblib/joblib/joblib/parallel.py", line 263, in __call__
for func, args, kwargs in self.items]
File "/home/travis/build/joblib/joblib/joblib/parallel.py", line 263, in <listcomp>
for func, args, kwargs in self.items]
File "/home/travis/build/joblib/joblib/joblib/test/test_parallel.py", line 518, in nested_function_outer
delayed(nested_function_inner)(j) for j in range(30))
File "/home/travis/build/joblib/joblib/joblib/parallel.py", line 998, in __call__
self.retrieve()
File "/home/travis/build/joblib/joblib/joblib/parallel.py", line 901, in retrieve
self._output.extend(job.get(timeout=self.timeout))
File "/home/travis/miniconda/envs/testenv/lib/python3.4/multiprocessing/pool.py", line 608, in get
raise self._value
File "/home/travis/miniconda/envs/testenv/lib/python3.4/multiprocessing/pool.py", line 119, in worker
result = (True, func(*args, **kwds))
File "/home/travis/build/joblib/joblib/joblib/_parallel_backends.py", line 563, in __call__
return self.func(*args, **kwargs)
File "/home/travis/build/joblib/joblib/joblib/parallel.py", line 263, in __call__
for func, args, kwargs in self.items]
File "/home/travis/build/joblib/joblib/joblib/parallel.py", line 263, in <listcomp>
for func, args, kwargs in self.items]
File "/home/travis/build/joblib/joblib/joblib/test/test_parallel.py", line 514, in nested_function_inner
delayed(exception_raiser)(j) for j in range(30))
File "/home/travis/build/joblib/joblib/joblib/parallel.py", line 985, in __call__
if self.dispatch_one_batch(iterator):
File "/home/travis/build/joblib/joblib/joblib/parallel.py", line 822, in dispatch_one_batch
self._pickle_cache)
File "/home/travis/build/joblib/joblib/joblib/parallel.py", line 253, in __init__
self.items = list(iterator_slice)
KeyError: 'range'I am not sure if it's deterministic or not. Let me restart the build. |
Contributor
Author
|
It's deterministic so there is a real regression... |
Contributor
|
It also makes |
Contributor
|
this is probably due to a change about |
Codecov Report
@@ Coverage Diff @@
## master #788 +/- ##
=========================================
- Coverage 95.43% 95.33% -0.1%
=========================================
Files 44 44
Lines 6307 6307
=========================================
- Hits 6019 6013 -6
- Misses 288 294 +6
Continue to review full report at Codecov.
|
Contributor
Author
|
@tomMoral I released cloudpickle 0.6.1 with your fix. |
yarikoptic
added a commit
to yarikoptic/joblib
that referenced
this pull request
Apr 12, 2019
* tag '0.13.0': Release 0.13.0 Use https (joblib#805) MTN bump loky to 2.4.2 (joblib#804) DOC: provide some useful variables for Makefile (joblib#794) DOC serialization and processes (joblib#803) ENH update loky 2.4.0 (joblib#802) FIX backward compatibility for nested backend (joblib#789) enable python 3.7 (joblib#795) memory: add test for call_and_shelve performance (joblib#791) FIX nested backend not changed by SequentialBackend (joblib#792) cloudpickle 0.6.0 (joblib#788) FIX nested backend setting n_jobs=-1 (joblib#785) Raises a more explicit exception when a corrupted MemorizedResult is loaded (joblib#768) Back to dev mode
yarikoptic
added a commit
to yarikoptic/joblib
that referenced
this pull request
Apr 12, 2019
* releases: Release 0.13.0 Use https (joblib#805) MTN bump loky to 2.4.2 (joblib#804) DOC: provide some useful variables for Makefile (joblib#794) DOC serialization and processes (joblib#803) ENH update loky 2.4.0 (joblib#802) FIX backward compatibility for nested backend (joblib#789) enable python 3.7 (joblib#795) memory: add test for call_and_shelve performance (joblib#791) FIX nested backend not changed by SequentialBackend (joblib#792) cloudpickle 0.6.0 (joblib#788) FIX nested backend setting n_jobs=-1 (joblib#785) Raises a more explicit exception when a corrupted MemorizedResult is loaded (joblib#768) Back to dev mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Among other fixes, this will remove the annoying deprecation warning about the imp module.