Raises a more explicit exception when a corrupted MemorizedResult is loaded#768
Merged
ogrisel merged 5 commits intojoblib:masterfrom Oct 5, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #768 +/- ##
==========================================
- Coverage 95.41% 95.27% -0.15%
==========================================
Files 44 44
Lines 6262 6287 +25
==========================================
+ Hits 5975 5990 +15
- Misses 287 297 +10
Continue to review full report at Codecov.
|
Contributor
Author
|
Another option of course is not to change anything. |
ogrisel
requested changes
Sep 5, 2018
Contributor
|
Also please add as an inline comment that KeyError is expected under Python 2.7 and ValueError under Python 3. |
Contributor
Author
|
Ok, I did this. |
Contributor
|
codecov is not 100% deterministic when reporting coverage on subprocess: they might be terminated before they have a chance to write their report. |
ogrisel
reviewed
Oct 5, 2018
| ) | ||
| except KeyError as e: | ||
| message = "is corrupted" | ||
| assert message in str(e.args) |
Contributor
There was a problem hiding this comment.
you could have used the pytest.raises context manager but this is fine.
Contributor
|
Thanks, merged! |
yarikoptic
added a commit
to yarikoptic/joblib
that referenced
this pull request
Apr 12, 2019
* tag '0.13.0': Release 0.13.0 Use https (joblib#805) MTN bump loky to 2.4.2 (joblib#804) DOC: provide some useful variables for Makefile (joblib#794) DOC serialization and processes (joblib#803) ENH update loky 2.4.0 (joblib#802) FIX backward compatibility for nested backend (joblib#789) enable python 3.7 (joblib#795) memory: add test for call_and_shelve performance (joblib#791) FIX nested backend not changed by SequentialBackend (joblib#792) cloudpickle 0.6.0 (joblib#788) FIX nested backend setting n_jobs=-1 (joblib#785) Raises a more explicit exception when a corrupted MemorizedResult is loaded (joblib#768) Back to dev mode
yarikoptic
added a commit
to yarikoptic/joblib
that referenced
this pull request
Apr 12, 2019
* releases: Release 0.13.0 Use https (joblib#805) MTN bump loky to 2.4.2 (joblib#804) DOC: provide some useful variables for Makefile (joblib#794) DOC serialization and processes (joblib#803) ENH update loky 2.4.0 (joblib#802) FIX backward compatibility for nested backend (joblib#789) enable python 3.7 (joblib#795) memory: add test for call_and_shelve performance (joblib#791) FIX nested backend not changed by SequentialBackend (joblib#792) cloudpickle 0.6.0 (joblib#788) FIX nested backend setting n_jobs=-1 (joblib#785) Raises a more explicit exception when a corrupted MemorizedResult is loaded (joblib#768) Back to dev mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When getting a reference with call_and_shelve, it's still possible that the underlying data gets corrupted (it raises an exception while trying to unpickle it).
This PR just wraps the .get method of MemorizedResult into a try/except, and adds an explicit message to the finally raised Exception.
I have found that pickle actually raises two kinds of Exceptions while unpickling. During my tests, it depended on the version of python that was used (KeyError for python 2.7 and ValueError for python 3).
Some existing tests were waiting for KeyError, so I used this one.
It would also be possible to use another one, like ValueError or a custom joblib exception, but it would require to change some tests, and could broke some users code..
I could also maybe just intercept the exception and add the explicit message, and reraise it again : in this way every user code that was expecting ValueError, or a KeyError could still catch it. It could still break code depending on what the user do with that exc.args (because we would have added an explicit message to it).