Test that show failure to close semaphore trackers#676
Merged
ogrisel merged 1 commit intojoblib:masterfrom Aug 23, 2018
Merged
Conversation
f38346c to
d1f7039
Compare
Codecov Report
@@ Coverage Diff @@
## master #676 +/- ##
==========================================
+ Coverage 95.23% 95.35% +0.11%
==========================================
Files 42 42
Lines 6128 6134 +6
==========================================
+ Hits 5836 5849 +13
+ Misses 292 285 -7
Continue to review full report at Codecov.
|
Contributor
Author
|
I've been out of the loop for a while, it seems that this has been fixed ? (except for the sklearn tests that have apparently failed to even start). Is #588 still worth rebasing ? at the time, this test causing timeout on appveyor was the last blocking point. Also I've seen Dask has been added as a backend, does it changes anything ? |
d1f7039 to
b340470
Compare
b340470 to
019652a
Compare
Contributor
Author
|
It seems the recent changes on nested parallel instances has fixed this too. It can be closed (or merged as a non regression test ?). Note: I had to trigger the CI twice because of pipelines failing randomly on travis, before everything finally becomes green. |
Contributor
|
This test is more suited to be included in |
ogrisel
pushed a commit
to joblib/loky
that referenced
this pull request
Aug 23, 2018
This fix the issue reported in joblib/joblib#676
Contributor
|
I merged the new test upstream in loky. Thanks! |
Contributor
|
ACtually let's merge this PR here as well as a non-regression test. |
yarikoptic
added a commit
to yarikoptic/joblib
that referenced
this pull request
Sep 4, 2018
* tag '0.12.3': (23 commits) Release 0.12.3 Loky 2.2.1 (joblib#760) FIX: FileSystemStoreBackend string representation only returning location (path) (joblib#765) Add optional dependency on psutil MAINT remove brittle time based assertion in test (joblib#761) Fix a bug in nesting level computation with FallbackToBackend(SequentialBackend()) (joblib#759) Make docstring more consistent with project style Improved performance of call_and_shelve (joblib#757) Better test name Fix default context handling (joblib#754) cloudpickle 0.5.5 (joblib#756) Fixed error where filter args was consuming kwargs (joblib#750) FIX pickle roundtrip for Memory and related classes. (joblib#746) test that passes but timeout appveyor because of unclosed semaphore tracker (joblib#676) DOC: fine tune compressor example dataset size for ReadTheDocs (joblib#753) FIX: MemorizedResult not picklable (joblib#752) [MRG] Better message with py27 when lz4 is not installed (joblib#740) MNT remove mutable default value for backend_options parameter (joblib#748) MNT create test file for _store_backends module (joblib#749) DOC consistently use memory rather than mem in memory.rst (joblib#744) ...
yarikoptic
added a commit
to yarikoptic/joblib
that referenced
this pull request
Sep 4, 2018
* releases: (23 commits) Release 0.12.3 Loky 2.2.1 (joblib#760) FIX: FileSystemStoreBackend string representation only returning location (path) (joblib#765) Add optional dependency on psutil MAINT remove brittle time based assertion in test (joblib#761) Fix a bug in nesting level computation with FallbackToBackend(SequentialBackend()) (joblib#759) Make docstring more consistent with project style Improved performance of call_and_shelve (joblib#757) Better test name Fix default context handling (joblib#754) cloudpickle 0.5.5 (joblib#756) Fixed error where filter args was consuming kwargs (joblib#750) FIX pickle roundtrip for Memory and related classes. (joblib#746) test that passes but timeout appveyor because of unclosed semaphore tracker (joblib#676) DOC: fine tune compressor example dataset size for ReadTheDocs (joblib#753) FIX: MemorizedResult not picklable (joblib#752) [MRG] Better message with py27 when lz4 is not installed (joblib#740) MNT remove mutable default value for backend_options parameter (joblib#748) MNT create test file for _store_backends module (joblib#749) DOC consistently use memory rather than mem in memory.rst (joblib#744) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test should pass well, but appveyor is going to timeout because some semaphore trackers will not close properly.