FIX: FileSystemStoreBackend string representation only returning location (path)#765
Merged
ogrisel merged 8 commits intojoblib:masterfrom Aug 30, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #765 +/- ##
==========================================
- Coverage 95.42% 95.35% -0.07%
==========================================
Files 44 44
Lines 6224 6245 +21
==========================================
+ Hits 5939 5955 +16
- Misses 285 290 +5
Continue to review full report at Codecov.
|
Member
|
Can you check that self.store_backend is not used in other classes |
Contributor
Author
I just did and you are right it was used in |
ogrisel
approved these changes
Aug 30, 2018
Contributor
ogrisel
left a comment
There was a problem hiding this comment.
LGTM, just a small comment to simplify a test.
joblib/test/test_memory.py
Outdated
| def test_filesystem_store_backend_repr(tmpdir): | ||
| # Verify string representation of a filesystem store backend. | ||
|
|
||
| repr_pattern = '{class_name}(location="{location}")' |
Contributor
There was a problem hiding this comment.
class_name is always FileSystemStoreBackend in this test. Please just write:
repr_pattern = 'FileSystemStoreBackend(location="{location}")'and then simplify the test accordingly.
Contributor
Author
There was a problem hiding this comment.
Indeed! I just pushed the fix.
Contributor
Author
|
@ogrisel, is it ok to merge ? |
ogrisel
reviewed
Aug 30, 2018
joblib/test/test_memory.py
Outdated
| memory = Memory(location=tmpdir.strpath, verbose=0) | ||
| memorized_func = memory.cache(my_func) | ||
|
|
||
| memorized_func_repr = '{class_name}(func={func}, location={location})' |
Contributor
There was a problem hiding this comment.
Actually class_name is always "MemorizedFunc" for memorized_func_repr and always "MemorizedResult" for memorized_result_repr so this test can also be simplified.
Contributor
Author
There was a problem hiding this comment.
Indeed... Also done with Memory.
yarikoptic
added a commit
to yarikoptic/joblib
that referenced
this pull request
Sep 4, 2018
* tag '0.12.3': (23 commits) Release 0.12.3 Loky 2.2.1 (joblib#760) FIX: FileSystemStoreBackend string representation only returning location (path) (joblib#765) Add optional dependency on psutil MAINT remove brittle time based assertion in test (joblib#761) Fix a bug in nesting level computation with FallbackToBackend(SequentialBackend()) (joblib#759) Make docstring more consistent with project style Improved performance of call_and_shelve (joblib#757) Better test name Fix default context handling (joblib#754) cloudpickle 0.5.5 (joblib#756) Fixed error where filter args was consuming kwargs (joblib#750) FIX pickle roundtrip for Memory and related classes. (joblib#746) test that passes but timeout appveyor because of unclosed semaphore tracker (joblib#676) DOC: fine tune compressor example dataset size for ReadTheDocs (joblib#753) FIX: MemorizedResult not picklable (joblib#752) [MRG] Better message with py27 when lz4 is not installed (joblib#740) MNT remove mutable default value for backend_options parameter (joblib#748) MNT create test file for _store_backends module (joblib#749) DOC consistently use memory rather than mem in memory.rst (joblib#744) ...
yarikoptic
added a commit
to yarikoptic/joblib
that referenced
this pull request
Sep 4, 2018
* releases: (23 commits) Release 0.12.3 Loky 2.2.1 (joblib#760) FIX: FileSystemStoreBackend string representation only returning location (path) (joblib#765) Add optional dependency on psutil MAINT remove brittle time based assertion in test (joblib#761) Fix a bug in nesting level computation with FallbackToBackend(SequentialBackend()) (joblib#759) Make docstring more consistent with project style Improved performance of call_and_shelve (joblib#757) Better test name Fix default context handling (joblib#754) cloudpickle 0.5.5 (joblib#756) Fixed error where filter args was consuming kwargs (joblib#750) FIX pickle roundtrip for Memory and related classes. (joblib#746) test that passes but timeout appveyor because of unclosed semaphore tracker (joblib#676) DOC: fine tune compressor example dataset size for ReadTheDocs (joblib#753) FIX: MemorizedResult not picklable (joblib#752) [MRG] Better message with py27 when lz4 is not installed (joblib#740) MNT remove mutable default value for backend_options parameter (joblib#748) MNT create test file for _store_backends module (joblib#749) DOC consistently use memory rather than mem in memory.rst (joblib#744) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #764
A non regression test is also provided.
With this PR, the snippets provided in #764 not returns the following: