TST add test for recursive_terminate with nested executor#148
Merged
TST add test for recursive_terminate with nested executor#148
Conversation
389b04a to
ea8ee85
Compare
Contributor
Author
|
The main issue with default |
ogrisel
reviewed
Aug 22, 2018
tests/_test_process_executor.py
Outdated
| initializer=_executor_mixin.initializer_event, | ||
| initargs=(_executor_mixin._test_event,)) | ||
| assert executor.submit(sleep_and_return, 0, 42).result() == 42 | ||
| if depth == 0: |
Contributor
There was a problem hiding this comment.
The variable name makes this test hard to understand: I would have expected depth to increase in the inner/nested calls.
tests/_test_process_executor.py
Outdated
| f = self.executor.submit(self._test_recursive_kill) | ||
| _executor_mixin._test_event.wait() | ||
| # Give some time to make sure psutil will detect the child workers | ||
| time.sleep(.5) |
Contributor
There was a problem hiding this comment.
This is no longer required, right?
af89401 to
2de9b26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix the issue reported in joblib/joblib#676